mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juan Gomez <juang@us.ibm.com>
To: marcelo@conectiva.com.br
Cc: linux-kernel@vger.kernel.org
Subject: kNFS(lockd) patch for linux-2.4.19
Date: Tue, 15 Oct 2002 09:10:34 -0700	[thread overview]
Message-ID: <OF12A74DE8.11CDD1B1-ON87256C53.0058AEE0@us.ibm.com> (raw)


Marcelo,

Have you had a chance to include this?

Juan

----- Forwarded by Juan Gomez/Almaden/IBM on 10/15/02 09:11 AM -----
                                                                                                                                             
                      Juan Gomez                                                                                                             
                      <gomez@cs.sjsu.edu>            To:       marcelo@conectiva.com.br                                                      
                      Sent by:                       cc:       trond.myklebust@fys.uio.no, linux-kernel@vger.kernel.org                      
                      linux-kernel-owner@vger        Subject:  kNFS(lockd) patch for linux-2.4.19                                            
                      .kernel.org                                                                                                            
                                                                                                                                             
                                                                                                                                             
                      10/08/02 01:59 PM                                                                                                      
                                                                                                                                             
                                                                                                                                             




Marcelo,

Would you please consider the attached patch for inclusion in 2.4..*?
The patch solves a faulty delay observed by the first client that access
lockd just after the grace period.

Juan
diff -ru linux-2.4.19/fs/lockd/svc.c
linux-2.4.19-plus-delay-patch/fs/lockd/svc.c
--- linux-2.4.19/fs/lockd/svc.c            Sun Oct 21 10:32:33 2001
+++ linux-2.4.19-plus-delay-patch/fs/lockd/svc.c             Tue Oct  8
13:19:40 2002
@@ -144,8 +144,7 @@
                          */
                         if (!nlmsvc_grace_period) {
                                     timeout = nlmsvc_retry_blocked();
-                        } else if (time_before(grace_period_expire,
jiffies))
-                                    clear_grace_period();
+                        }

                         /*
                          * Find a socket with data available and call its
@@ -163,6 +162,22 @@

                         dprintk("lockd: request from %08x\n",

(unsigned)ntohl(rqstp->rq_addr.sin_addr.s_addr));
+                /*
+                 * We need to do the clear/grace period here and not
before
+                 * svc_recv() because svc_recv() may sleep longer than the

+                 * grace period and the first request may be falsely
processed
+                 * as if the server was in the grace period when it was
not
+                 * causing unnecessary delays for the first request
received.
+                 * Juan C. Gomez j_carlos_gome@yahoo.com
+                 */
+
+                if (nlmsvc_grace_period
+                    &&
+                    time_before(grace_period_expire, jiffies)) {
+                         clear_grace_period();
+                }
+
+

                         /*
                          * Look up the NFS client handle. The handle is
needed for

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/




             reply	other threads:[~2002-10-15 16:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-15 16:10 Juan Gomez [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-10-16 17:02 Juan Gomez
2002-10-08 20:59 Juan Gomez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OF12A74DE8.11CDD1B1-ON87256C53.0058AEE0@us.ibm.com \
    --to=juang@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®