* kNFS(lockd) patch for linux-2.4.19
@ 2002-10-15 16:10 Juan Gomez
0 siblings, 0 replies; 3+ messages in thread
From: Juan Gomez @ 2002-10-15 16:10 UTC (permalink / raw)
To: marcelo; +Cc: linux-kernel
Marcelo,
Have you had a chance to include this?
Juan
----- Forwarded by Juan Gomez/Almaden/IBM on 10/15/02 09:11 AM -----
Juan Gomez
<gomez@cs.sjsu.edu> To: marcelo@conectiva.com.br
Sent by: cc: trond.myklebust@fys.uio.no, linux-kernel@vger.kernel.org
linux-kernel-owner@vger Subject: kNFS(lockd) patch for linux-2.4.19
.kernel.org
10/08/02 01:59 PM
Marcelo,
Would you please consider the attached patch for inclusion in 2.4..*?
The patch solves a faulty delay observed by the first client that access
lockd just after the grace period.
Juan
diff -ru linux-2.4.19/fs/lockd/svc.c
linux-2.4.19-plus-delay-patch/fs/lockd/svc.c
--- linux-2.4.19/fs/lockd/svc.c Sun Oct 21 10:32:33 2001
+++ linux-2.4.19-plus-delay-patch/fs/lockd/svc.c Tue Oct 8
13:19:40 2002
@@ -144,8 +144,7 @@
*/
if (!nlmsvc_grace_period) {
timeout = nlmsvc_retry_blocked();
- } else if (time_before(grace_period_expire,
jiffies))
- clear_grace_period();
+ }
/*
* Find a socket with data available and call its
@@ -163,6 +162,22 @@
dprintk("lockd: request from %08x\n",
(unsigned)ntohl(rqstp->rq_addr.sin_addr.s_addr));
+ /*
+ * We need to do the clear/grace period here and not
before
+ * svc_recv() because svc_recv() may sleep longer than the
+ * grace period and the first request may be falsely
processed
+ * as if the server was in the grace period when it was
not
+ * causing unnecessary delays for the first request
received.
+ * Juan C. Gomez j_carlos_gome@yahoo.com
+ */
+
+ if (nlmsvc_grace_period
+ &&
+ time_before(grace_period_expire, jiffies)) {
+ clear_grace_period();
+ }
+
+
/*
* Look up the NFS client handle. The handle is
needed for
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread* kNFS(lockd) patch for linux-2.4.19
@ 2002-10-16 17:02 Juan Gomez
0 siblings, 0 replies; 3+ messages in thread
From: Juan Gomez @ 2002-10-16 17:02 UTC (permalink / raw)
To: neilb; +Cc: linux-kernel, nfs, trond.myklebust
Neil,
Here is the same patch for 2.4.* hopefuly you can get this in the kernel as
well as I have not received any reply from Marcelo.
Juan
----- Forwarded by Juan Gomez/Almaden/IBM on 10/16/02 10:00 AM -----
Juan Gomez
To: marcelo@conectiva.com.br
10/15/02 09:10 AM cc: linux-kernel@vger.kernel.org
From: Juan Gomez/Almaden/IBM@IBMUS
Subject: kNFS(lockd) patch for linux-2.4.19
Marcelo,
Have you had a chance to include this?
Juan
----- Forwarded by Juan Gomez/Almaden/IBM on 10/15/02 09:11 AM -----
Juan Gomez
<gomez@cs.sjsu.edu> To: marcelo@conectiva.com.br
Sent by: cc: trond.myklebust@fys.uio.no, linux-kernel@vger.kernel.org
linux-kernel-owner@vger Subject: kNFS(lockd) patch for linux-2.4.19
.kernel.org
10/08/02 01:59 PM
Marcelo,
Would you please consider the attached patch for inclusion in 2.4..*?
The patch solves a faulty delay observed by the first client that access
lockd just after the grace period.
Juan
diff -ru linux-2.4.19/fs/lockd/svc.c
linux-2.4.19-plus-delay-patch/fs/lockd/svc.c
--- linux-2.4.19/fs/lockd/svc.c Sun Oct 21 10:32:33 2001
+++ linux-2.4.19-plus-delay-patch/fs/lockd/svc.c Tue Oct 8
13:19:40 2002
@@ -144,8 +144,7 @@
*/
if (!nlmsvc_grace_period) {
timeout = nlmsvc_retry_blocked();
- } else if (time_before(grace_period_expire,
jiffies))
- clear_grace_period();
+ }
/*
* Find a socket with data available and call its
@@ -163,6 +162,22 @@
dprintk("lockd: request from %08x\n",
(unsigned)ntohl(rqstp->rq_addr.sin_addr.s_addr));
+ /*
+ * We need to do the clear/grace period here and not
before
+ * svc_recv() because svc_recv() may sleep longer than the
+ * grace period and the first request may be falsely
processed
+ * as if the server was in the grace period when it was
not
+ * causing unnecessary delays for the first request
received.
+ * Juan C. Gomez j_carlos_gome@yahoo.com
+ */
+
+ if (nlmsvc_grace_period
+ &&
+ time_before(grace_period_expire, jiffies)) {
+ clear_grace_period();
+ }
+
+
/*
* Look up the NFS client handle. The handle is
needed for
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread* kNFS(lockd) patch for linux-2.4.19
@ 2002-10-08 20:59 Juan Gomez
0 siblings, 0 replies; 3+ messages in thread
From: Juan Gomez @ 2002-10-08 20:59 UTC (permalink / raw)
To: marcelo; +Cc: trond.myklebust, linux-kernel
Marcelo,
Would you please consider the attached patch for inclusion in 2.4..*?
The patch solves a faulty delay observed by the first client that access
lockd just after the grace period.
Juan
diff -ru linux-2.4.19/fs/lockd/svc.c linux-2.4.19-plus-delay-patch/fs/lockd/svc.c
--- linux-2.4.19/fs/lockd/svc.c Sun Oct 21 10:32:33 2001
+++ linux-2.4.19-plus-delay-patch/fs/lockd/svc.c Tue Oct 8 13:19:40 2002
@@ -144,8 +144,7 @@
*/
if (!nlmsvc_grace_period) {
timeout = nlmsvc_retry_blocked();
- } else if (time_before(grace_period_expire, jiffies))
- clear_grace_period();
+ }
/*
* Find a socket with data available and call its
@@ -163,6 +162,22 @@
dprintk("lockd: request from %08x\n",
(unsigned)ntohl(rqstp->rq_addr.sin_addr.s_addr));
+ /*
+ * We need to do the clear/grace period here and not before
+ * svc_recv() because svc_recv() may sleep longer than the
+ * grace period and the first request may be falsely processed
+ * as if the server was in the grace period when it was not
+ * causing unnecessary delays for the first request received.
+ * Juan C. Gomez j_carlos_gome@yahoo.com
+ */
+
+ if (nlmsvc_grace_period
+ &&
+ time_before(grace_period_expire, jiffies)) {
+ clear_grace_period();
+ }
+
+
/*
* Look up the NFS client handle. The handle is needed for
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-10-16 16:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-10-15 16:10 kNFS(lockd) patch for linux-2.4.19 Juan Gomez
-- strict thread matches above, loose matches on Subject: below --
2002-10-16 17:02 Juan Gomez
2002-10-08 20:59 Juan Gomez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®