From: "Mala Anand" <manand@us.ibm.com>
To: Robert Olsson <Robert.Olsson@data.slu.se>
Cc: "Bill Hartner" <bhartner@us.ibm.com>,
davem@redhat.com, jamal <hadi@cyberus.ca>,
linux-kernel@vger.kernel.org, "Mala Anand" <manand@us.ibm.com>,
netdev@oss.sgi.com, Robert Olsson <Robert.Olsson@data.slu.se>
Subject: Re: [Lse-tech] Re: (RFC): SKB Initialization
Date: Mon, 26 Aug 2002 21:53:37 -0500 [thread overview]
Message-ID: <OF815FDA48.08A89D80-ON87256C22.000D9ED4@boulder.ibm.com> (raw)
Robert Olsson wrote..
>In slab terms you moved part of the destructor to the constructor
>but the main problem is still there. The skb entered the "wrong" CPU
>so to be "reused from the slab again" the work has to done regardless
>if it's in the constructor or destructor.
That is true if it is a uni processor but in smp the initialization,
if happened in two different CPUs, affects performance due to cache
effects.
The problem of object (skb) allocation, usage and deallocation occurring
in multiple CPUs need to be addressed separately. This patch is not
attempting to address that.
>Eventually if we accept some cache misses a skb could possibly be
re-routed
>to the proper slab/CPU for this we would need some skb coloring.
You still can do this. I don't see skbinit patch hindering this.
Regards,
Mala
Mala Anand
IBM Linux Technology Center - Kernel Performance
E-mail:manand@us.ibm.com
http://www-124.ibm.com/developerworks/opensource/linuxperf
http://www-124.ibm.com/developerworks/projects/linuxperf
Phone:838-8088; Tie-line:678-8088
next reply other threads:[~2002-08-27 2:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-27 2:53 Mala Anand [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-09-03 3:47 Mala Anand
2002-08-27 13:18 Mala Anand
2002-08-27 15:49 ` jamal
2002-08-26 13:04 Mala Anand
2002-08-26 19:28 ` Robert Olsson
2002-08-27 10:17 ` jamal
2002-08-25 20:12 Mala Anand
2002-08-26 1:02 ` jamal
2002-08-25 16:17 jamal
2002-08-25 22:51 ` David S. Miller
2002-08-23 23:38 Mala Anand
2002-08-23 23:55 ` David S. Miller
2002-08-23 23:14 Mala Anand
2002-08-23 14:44 Mala Anand
2002-08-23 16:39 ` Dave Hansen
2002-08-23 20:12 ` Bill Hartner
2002-08-23 20:30 ` Dave Hansen
2002-08-23 23:36 ` Troy Wilson
2002-08-23 20:51 ` Rick Lindsley
2002-08-23 22:41 ` David S. Miller
2002-08-22 17:22 Mala Anand
2002-08-22 18:32 ` Benjamin LaHaise
2002-08-22 19:02 ` Dave Hansen
2002-08-22 22:05 ` William Lee Irwin III
2002-08-23 19:09 ` Bill Hartner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF815FDA48.08A89D80-ON87256C22.000D9ED4@boulder.ibm.com \
--to=manand@us.ibm.com \
--cc=Robert.Olsson@data.slu.se \
--cc=bhartner@us.ibm.com \
--cc=davem@redhat.com \
--cc=hadi@cyberus.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®