* [PATCH] arm64: boot: dts: rockchip: Fix led pinctrl of lubancat 1
@ 2023-12-24 7:50 Andy Yan
2023-12-24 9:01 ` Krzysztof Kozlowski
2023-12-24 12:44 ` Zhang Ning
0 siblings, 2 replies; 3+ messages in thread
From: Andy Yan @ 2023-12-24 7:50 UTC (permalink / raw)
To: heiko
Cc: krzysztof.kozlowski+dt, robh+dt, lasstp5011, devicetree,
linux-arm-kernel, linux-kernel, linux-rockchip, zhangn1985,
Andy Yan
According to the sch, the gpio control sys_led
is GPIO0_C5.
Fixes: 8d94da58de53 ("arm64: dts: rockchip: Add EmbedFire LubanCat 1")
Reported-by: zhangn1985@outlook.com
Closes: https://lore.kernel.org/linux-rockchip/OS0P286MB06412D049D8BF7B063D41350CD95A@OS0P286MB0641.JPNP286.PROD.OUTLOOK.COM/T/#u
Signed-off-by: Andy Yan <andyshrk@163.com>
---
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
index 1c6d83b47cd2..6ecdf5d28339 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
@@ -455,7 +455,7 @@ &pcie2x1 {
&pinctrl {
leds {
sys_led_pin: sys-status-led-pin {
- rockchip,pins = <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
+ rockchip,pins = <0 RK_PC5 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: boot: dts: rockchip: Fix led pinctrl of lubancat 1
2023-12-24 7:50 [PATCH] arm64: boot: dts: rockchip: Fix led pinctrl of lubancat 1 Andy Yan
@ 2023-12-24 9:01 ` Krzysztof Kozlowski
2023-12-24 12:44 ` Zhang Ning
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-24 9:01 UTC (permalink / raw)
To: Andy Yan, heiko
Cc: krzysztof.kozlowski+dt, robh+dt, lasstp5011, devicetree,
linux-arm-kernel, linux-kernel, linux-rockchip, zhangn1985
On 24/12/2023 08:50, Andy Yan wrote:
> According to the sch, the gpio control sys_led
> is GPIO0_C5.
For the future:
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
There is no "boot".
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: boot: dts: rockchip: Fix led pinctrl of lubancat 1
2023-12-24 7:50 [PATCH] arm64: boot: dts: rockchip: Fix led pinctrl of lubancat 1 Andy Yan
2023-12-24 9:01 ` Krzysztof Kozlowski
@ 2023-12-24 12:44 ` Zhang Ning
1 sibling, 0 replies; 3+ messages in thread
From: Zhang Ning @ 2023-12-24 12:44 UTC (permalink / raw)
To: Andy Yan
Cc: heiko, krzysztof.kozlowski+dt, robh+dt, lasstp5011, devicetree,
linux-arm-kernel, linux-kernel, linux-rockchip
O Sun, Dec 24, 2023 at 03:50:01PM +0800, Andy Yan wrote:
> According to the sch, the gpio control sys_led
> is GPIO0_C5.
>
> Fixes: 8d94da58de53 ("arm64: dts: rockchip: Add EmbedFire LubanCat 1")
>Reported-by: zhangn1985@outlook.com
Reported-by: Zhang Ning <zhangn1985@outlook.com>
in case if have rev2.
> Closes: https://lore.kernel.org/linux-rockchip/OS0P286MB06412D049D8BF7B063D41350CD95A@OS0P286MB0641.JPNP286.PROD.OUTLOOK.COM/T/#u
> Signed-off-by: Andy Yan <andyshrk@163.com>
> ---
>
> arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> index 1c6d83b47cd2..6ecdf5d28339 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> @@ -455,7 +455,7 @@ &pcie2x1 {
> &pinctrl {
> leds {
> sys_led_pin: sys-status-led-pin {
> - rockchip,pins = <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
> + rockchip,pins = <0 RK_PC5 RK_FUNC_GPIO &pcfg_pull_none>;
> };
> };
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-24 12:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-24 7:50 [PATCH] arm64: boot: dts: rockchip: Fix led pinctrl of lubancat 1 Andy Yan
2023-12-24 9:01 ` Krzysztof Kozlowski
2023-12-24 12:44 ` Zhang Ning
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®