From: Eddy Tao <taoyuan_eddy@hotmail.com>
To: Simon Horman <simon.horman@corigine.com>
Cc: netdev@vger.kernel.org, Pravin B Shelar <pshelar@ovn.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
dev@openvswitch.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v1 1/1] net: openvswitch: ovs_packet_cmd_execute put sw_flow mainbody in stack
Date: Mon, 20 Feb 2023 11:04:01 +0800 [thread overview]
Message-ID: <OS3P286MB22957AE85FC76EAB8988745BF5A49@OS3P286MB2295.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <Y/IqJvWEJ+UNOs6i@corigine.com>
Hi, Simon:
To have better visibility of the effect of the patch, i did another
test below
Disabling data-path flow installation to steer traffic to slow path
only, thus I can observe the performance on slow path, where
ovs_packet_cmd_execute is extensively used
Testing topology
|-----|
nic1--| |--nic1
nic2--| |--nic2
VM1(16cpus) | ovs | VM2(16 cpus)
nic3--| |--nic3
nic4--| |--nic4
|-----|
2 netperf client threads on each vnic
netperf -H $peer -p $((port+$i)) -t TCP_STREAM -l 60
netperf -H $peer -p $((port+$i)) -t TCP_RR -l 60 -- -R 1 -r 120,240
netperf -H $peer -p $((port+$i)) -t TCP_CRR -l 60 -- -R 1 -r 120,240
Mode Iterations Variance Average
TCP_STREAM 10 %3.83 1433 ==> before the change
TCP_STREAM 10 %3.39 1504 ==> after the change
TCP_RR 10 %2.35 45145 ==> before the change
TCP_RR 10 %1.06 47250 ==> after the change
TCP_CRR 10 %0.54 11310 ==> before the change
TCP_CRR 10 %2.64 12741 ==> after the change
Considering the size and simplicity of the patch, i would say the
performance benefit is decent.
Thanks
eddy
next prev parent reply other threads:[~2023-02-20 3:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 6:53 Eddy Tao
2023-02-19 13:54 ` Simon Horman
2023-02-19 14:46 ` Eddy Tao
2023-02-19 14:51 ` Eddy Tao
2023-02-20 3:04 ` Eddy Tao [this message]
2023-02-20 3:44 ` [ovs-dev] " Eddy Tao
2023-02-20 7:11 ` Eddy Tao
2023-02-20 10:37 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS3P286MB22957AE85FC76EAB8988745BF5A49@OS3P286MB2295.JPNP286.PROD.OUTLOOK.COM \
--to=taoyuan_eddy@hotmail.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®