mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Min Li <min.li.xe@renesas.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "richardcochran@gmail.com" <richardcochran@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"andrew@lunn.ch" <andrew@lunn.ch>
Subject: RE: [PATCH net v2 2/2] ptp: idt82p33: implement double dco time correction
Date: Mon, 20 Sep 2021 14:08:37 +0000	[thread overview]
Message-ID: <OS3PR01MB65935EC20F350036340F3348BAA09@OS3PR01MB6593.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20210917140631.696aadc9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

>   > On Fri, Jun 25, 2021 at 02:24:24PM +0000, Min Li wrote:
>   > > How would you suggest to implement the change that make the new
> driver behavior optional?
>   > I would say, module parameter or debugfs knob.
> 
> Aright, in which case devlink or debugfs, please.
> 
> > > What's the point of this? Just rename the file in the filesystem.
> >
> > We use this parameter to specify firmware so that module can be
> > autoloaded /etc/modprobe.d/modname.conf
> 
> Sorry, I don't understand. The firmware is in /lib/firmware.
> Previously you used a card coded name (whatever FW_FILENAME is,
> "idt82p33xxx.bin"?). This patch adds the ability to change the firmware file
> name by a module param.
> 
> Now let me repeat the question - what's the point of user changing the
> requested firmware name if they can simply rename the file?

We have different firmware named after different 1588 profiles. If we rename firmware, it would make
every profile  look same and confusing. On the other hand, with this module parameter, we can have phc
module auto start with correct firmware.

Thanks

Min

  reply	other threads:[~2021-09-20 14:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-17 14:39 [PATCH net v2 1/2] ptp: idt82p33: optimize idt82p33_adjtime min.li.xe
2021-09-17 14:39 ` [PATCH net v2 2/2] ptp: idt82p33: implement double dco time correction min.li.xe
2021-09-17 19:54   ` Jakub Kicinski
2021-09-17 20:19     ` Min Li
2021-09-17 21:06       ` Jakub Kicinski
2021-09-20 14:08         ` Min Li [this message]
2021-09-20 19:14           ` Jakub Kicinski
2021-09-20 15:13         ` Min Li
2021-09-20 16:49           ` Andrew Lunn
2021-09-17 19:58 ` [PATCH net v2 1/2] ptp: idt82p33: optimize idt82p33_adjtime Andrew Lunn
  -- strict thread matches above, loose matches on Subject: below --
2021-09-17 20:50 min.li.xe
2021-09-17 20:50 ` [PATCH net v2 2/2] ptp: idt82p33: implement double dco time correction min.li.xe
2021-09-17 21:08   ` Jakub Kicinski
2021-09-17 21:14     ` Andrew Lunn
2021-06-29 18:29 [PATCH net v2 1/2] ptp: idt82p33: optimize idt82p33_adjtime min.li.xe
2021-06-29 18:29 ` [PATCH net v2 2/2] ptp: idt82p33: implement double dco time correction min.li.xe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OS3PR01MB65935EC20F350036340F3348BAA09@OS3PR01MB6593.jpnprd01.prod.outlook.com \
    --to=min.li.xe@renesas.com \
    --cc=andrew@lunn.ch \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®