mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: min.li.xe@renesas.com, richardcochran@gmail.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2 2/2] ptp: idt82p33: implement double dco time correction
Date: Fri, 17 Sep 2021 23:14:22 +0200	[thread overview]
Message-ID: <YUUFLshlVw+s2TDw@lunn.ch> (raw)
In-Reply-To: <20210917140856.01a00f2e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On Fri, Sep 17, 2021 at 02:08:56PM -0700, Jakub Kicinski wrote:
> On Fri, 17 Sep 2021 16:50:21 -0400 min.li.xe@renesas.com wrote:
> > Current adjtime is not accurate when delta is smaller than 10000ns. So
> > for small time correction, we will switch to DCO mode to pull phase
> > more precisely in one second duration.
> 
> 1. *Never* repost the patches when there is an ongoing discussion.
> 
> 2. Always CC people who gave you feedback on the previous version.

And adding to this, please wait at least a day between reposts, to
give people times to actually review the code and make comments.

Thanks
	Andrew

  reply	other threads:[~2021-09-17 21:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-17 20:50 [PATCH net v2 1/2] ptp: idt82p33: optimize idt82p33_adjtime min.li.xe
2021-09-17 20:50 ` [PATCH net v2 2/2] ptp: idt82p33: implement double dco time correction min.li.xe
2021-09-17 21:08   ` Jakub Kicinski
2021-09-17 21:14     ` Andrew Lunn [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-09-17 14:39 [PATCH net v2 1/2] ptp: idt82p33: optimize idt82p33_adjtime min.li.xe
2021-09-17 14:39 ` [PATCH net v2 2/2] ptp: idt82p33: implement double dco time correction min.li.xe
2021-09-17 19:54   ` Jakub Kicinski
2021-09-17 20:19     ` Min Li
2021-09-17 21:06       ` Jakub Kicinski
2021-09-20 14:08         ` Min Li
2021-09-20 19:14           ` Jakub Kicinski
2021-09-20 15:13         ` Min Li
2021-09-20 16:49           ` Andrew Lunn
2021-06-29 18:29 [PATCH net v2 1/2] ptp: idt82p33: optimize idt82p33_adjtime min.li.xe
2021-06-29 18:29 ` [PATCH net v2 2/2] ptp: idt82p33: implement double dco time correction min.li.xe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUUFLshlVw+s2TDw@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=min.li.xe@renesas.com \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®