RE: [PATCH v7 0/6] thermal: renesas: Add support for RZ/G3E

[John Madieu <john.madieu.xa@bp.renesas.com>]

Hi Rob,

Thanks for the feedback!

> -----Original Message-----
> From: Rob Herring (Arm) <robh@kernel.org>
> Sent: Monday, August 18, 2025 8:25 PM
> To: John Madieu <john.madieu.xa@bp.renesas.com>
> Subject: Re: [PATCH v7 0/6] thermal: renesas: Add support for RZ/G3E
> 
> 
> On Mon, 18 Aug 2025 18:28:46 +0200, John Madieu wrote:
> > This series adds support for the temperature sensor unit (TSU) found
> > on the Renesas RZ/G3E SoC.
> >
> > The series consists of 5 patches (one of which is not related to the
> > thermal
> > framework) that progressively add TSU support as follows:
> > - patch 1/6:    adds syscon/regmap support for accessing system
> controller
> >                 registers, enabling access to TSU calibration values
> >
> > - patch 2-6/6:  adds dt-bindings, actual driver, DT node, and config
> symbol.
> >
> > Patch 1/6 has been duplicated at [1] in USB series. This series
> > addresses comments got from there.
> >
> > Changes:
> >
> > v1 -> v2
> >  * Fix yaml warnings from dt-binding
> >  * Update IRQ names to reflect TSU expectations
> >
> > v2 -> v3
> >  * Remove useless 'renesas,tsu-operating-mode' property
> >
> > v3 -> v4
> >  * Improve commit messages
> >
> > v4 -> v5
> >  * Remove useless curly braces on single line-protected scoped guards
> >
> > v5 -> v6
> >  * Minor typo fix
> >  * Constify regmap config in patch 1/5
> >
> > v6 -> v7
> >  * Update DTS trim priperty name and specifier, updading the
> > documentation  accordingly
> >  * Refactor main driver: remove spinlock usage, using polling timeout
> > as computed  from datasheet. Also use polling for get_temp() while
> > using IRQ for trip-point  cross detection, and finally add both runtime
> and sleep PM support.
> >  * Add new patch to update sys #address-cells as trim specifier now
> > requires an  offet from sys base
> >
> > Regards,
> >
> > [1]
> > https://lore.kernel.org/all/20250808061806.2729274-2-claudiu.beznea.uj
> > @bp.renesas.com/
> >
> >
> > John Madieu (6):
> >   soc: renesas: rz-sysc: Add syscon/regmap support
> >   dt-bindings: thermal: r9a09g047-tsu: Document the TSU unit
> >   thermal: renesas: rzg3e: Add thermal driver for the Renesas RZ/G3E SoC
> >   arm64: dts: renesas: r9a09g047: Add #address-cells property in sys
> >     node
> >   arm64: dts: renesas: r9a09g047: Add TSU node
> >   arm64: defconfig: Enable the Renesas RZ/G3E thermal driver
> >
> >  .../thermal/renesas,r9a09g047-tsu.yaml        |  87 +++
> >  MAINTAINERS                                   |   7 +
> >  arch/arm64/boot/dts/renesas/r9a09g047.dtsi    |  49 ++
> >  arch/arm64/configs/defconfig                  |   1 +
> >  drivers/soc/renesas/Kconfig                   |   1 +
> >  drivers/soc/renesas/r9a08g045-sysc.c          |   1 +
> >  drivers/soc/renesas/r9a09g047-sys.c           |   1 +
> >  drivers/soc/renesas/r9a09g057-sys.c           |   1 +
> >  drivers/soc/renesas/rz-sysc.c                 |  28 +-
> >  drivers/soc/renesas/rz-sysc.h                 |   2 +
> >  drivers/thermal/renesas/Kconfig               |   7 +
> >  drivers/thermal/renesas/Makefile              |   1 +
> >  drivers/thermal/renesas/rzg3e_thermal.c       | 575 ++++++++++++++++++
> >  13 files changed, 760 insertions(+), 1 deletion(-)  create mode
> > 100644
> > Documentation/devicetree/bindings/thermal/renesas,r9a09g047-tsu.yaml
> >  create mode 100644 drivers/thermal/renesas/rzg3e_thermal.c
> >
> > --
> > 2.25.1
> >
> >
> >
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then make sure
> dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> This patch series was applied (using b4) to base:
>  Base: attempting to guess base-commit...
>  Base: tags/v6.17-rc1-12-g0a0e0852f3f3 (best guess, 10/11 blobs matched)
> 
> If this is not the correct base, please add 'base-commit' tag (or use b4
> which does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/renesas/'
> for 20250818162859.9661-1-john.madieu.xa@bp.renesas.com:
> 
> arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dtb: system-
> controller@10430000 (renesas,r9a09g047-sys): '#address-cells' does not
> match any of the regexes: '^pinctrl-[0-9]+$'
> 	from schema $id:
> http://devicetree.org/schemas/soc/renesas/renesas,r9a09g057-sys.yaml#
> 

Indeed, I modified the sys node adding #address-cells without documenting it.
That patch will be dropped in next series.

Regards,
John

> 
> 
>