mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Madieu <john.madieu.xa@bp.renesas.com>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: "andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"geert+renesas@glider.be" <geert+renesas@glider.be>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	"robh@kernel.org" <robh@kernel.org>,
	Biju Das <biju.das.jz@bp.renesas.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"john.madieu@gmail.com" <john.madieu@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"magnus.damm@gmail.com" <magnus.damm@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH v2 3/3] arm64: dts: renesas: rzg3e-smarc-som: Enable eth{0-1} (GBETH) interfaces
Date: Thu, 19 Jun 2025 11:09:49 +0000	[thread overview]
Message-ID: <OSCPR01MB146474526AD10BFCF587A8F85FF7DA@OSCPR01MB14647.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CA+V-a8uizu5MCur_=g5vJyWbWSTSP2J6FkQ89JB8ges7GWdsjg@mail.gmail.com>

Hi Prabhakar,

> -----Original Message-----
> From: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> Sent: Thursday, June 19, 2025 11:00 AM
> To: John Madieu <john.madieu.xa@bp.renesas.com>
> Subject: Re: [PATCH v2 3/3] arm64: dts: renesas: rzg3e-smarc-som: Enable
> eth{0-1} (GBETH) interfaces
> 
> Hi John,
> 
> Thank you for the patch.
> 
> On Wed, Jun 11, 2025 at 7:20 AM John Madieu
> <john.madieu.xa@bp.renesas.com> wrote:
> >
> > Enable the Gigabit Ethernet Interfaces (GBETH) populated on the RZ/G3E
> > SMARC EVK
> >
> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Tested-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com>
> > ---
> >  .../boot/dts/renesas/rzg3e-smarc-som.dtsi     | 106 ++++++++++++++++++
> >  1 file changed, 106 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> > b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> > index f99a09d04ddd..4b4c7f3381ad 100644
> > --- a/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> > @@ -26,6 +26,8 @@ / {
> >         compatible = "renesas,rzg3e-smarcm", "renesas,r9a09g047e57",
> > "renesas,r9a09g047";
> >
> >         aliases {
> > +               ethernet0 = &eth0;
> > +               ethernet1 = &eth1;
> >                 i2c2 = &i2c2;
> >                 mmc0 = &sdhi0;
> >                 mmc2 = &sdhi2;
> > @@ -77,6 +79,74 @@ &audio_extal_clk {
> >         clock-frequency = <48000000>;
> >  };
> >
> > +&eth0 {
> > +       phy-handle = <&phy0>;
> > +       phy-mode = "rgmii-id";
> > +
> > +       pinctrl-0 = <&eth0_pins>;
> > +       pinctrl-names = "default";
> > +       status = "okay";
> > +
> > +       mdio {
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> > +               compatible = "snps,dwmac-mdio";
> > +
> > +               phy0: ethernet-phy@7 {
> > +                       compatible = "ethernet-phy-id0022.1640",
> > +                                    "ethernet-phy-ieee802.3-c22";
> > +                       reg = <7>;
> > +                       interrupts-extended = <&icu 3
> IRQ_TYPE_LEVEL_LOW>;
> > +                       rxc-skew-psec = <1400>;
> > +                       txc-skew-psec = <1400>;
> > +                       rxdv-skew-psec = <0>;
> > +                       txdv-skew-psec = <0>;
> > +                       rxd0-skew-psec = <0>;
> > +                       rxd1-skew-psec = <0>;
> > +                       rxd2-skew-psec = <0>;
> > +                       rxd3-skew-psec = <0>;
> > +                       txd0-skew-psec = <0>;
> > +                       txd1-skew-psec = <0>;
> > +                       txd2-skew-psec = <0>;
> > +                       txd3-skew-psec = <0>;
> > +               };
> > +       };
> > +};
> > +
> > +&eth1 {
> > +       phy-handle = <&phy1>;
> > +       phy-mode = "rgmii-id";
> > +
> > +       pinctrl-0 = <&eth1_pins>;
> > +       pinctrl-names = "default";
> > +       status = "okay";
> > +
> > +       mdio {
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> > +               compatible = "snps,dwmac-mdio";
> > +
> > +               phy1: ethernet-phy@7 {
> > +                       compatible = "ethernet-phy-id0022.1640",
> > +                                    "ethernet-phy-ieee802.3-c22";
> > +                       reg = <7>;
> > +                       interrupts-extended = <&icu 16
> IRQ_TYPE_LEVEL_LOW>;
> > +                       rxc-skew-psec = <1400>;
> > +                       txc-skew-psec = <1400>;
> > +                       rxdv-skew-psec = <0>;
> > +                       txdv-skew-psec = <0>;
> > +                       rxd0-skew-psec = <0>;
> > +                       rxd1-skew-psec = <0>;
> > +                       rxd2-skew-psec = <0>;
> > +                       rxd3-skew-psec = <0>;
> > +                       txd0-skew-psec = <0>;
> > +                       txd1-skew-psec = <0>;
> > +                       txd2-skew-psec = <0>;
> > +                       txd3-skew-psec = <0>;
> > +               };
> > +       };
> > +};
> > +
> >  &gpu {
> >         status = "okay";
> >         mali-supply = <&reg_vdd0p8v_others>; @@ -103,6 +173,42 @@
> > raa215300: pmic@12 {  };
> >
> >  &pinctrl {
> > +       eth0_pins: eth0 {
> > +               pinmux = <RZG3E_PORT_PINMUX(A, 1, 1)>, /* MDC */
> > +                        <RZG3E_PORT_PINMUX(A, 0, 1)>, /* MDIO */
> > +                        <RZG3E_PORT_PINMUX(C, 2, 15)>, /* PHY_INTR
> (IRQ2) */
> > +                        <RZG3E_PORT_PINMUX(C, 1, 1)>, /* RXD3 */
> > +                        <RZG3E_PORT_PINMUX(C, 0, 1)>, /* RXD2 */
> > +                        <RZG3E_PORT_PINMUX(B, 7, 1)>, /* RXD1 */
> > +                        <RZG3E_PORT_PINMUX(B, 6, 1)>, /* RXD0 */
> > +                        <RZG3E_PORT_PINMUX(B, 0, 1)>, /* RXC */
> > +                        <RZG3E_PORT_PINMUX(A, 2, 1)>, /* RX_CTL */
> > +                        <RZG3E_PORT_PINMUX(B, 5, 1)>, /* TXD3 */
> > +                        <RZG3E_PORT_PINMUX(B, 4, 1)>, /* TXD2 */
> > +                        <RZG3E_PORT_PINMUX(B, 3, 1)>, /* TXD1 */
> > +                        <RZG3E_PORT_PINMUX(B, 2, 1)>, /* TXD0 */
> > +                        <RZG3E_PORT_PINMUX(B, 1, 1)>, /* TXC */
> > +                        <RZG3E_PORT_PINMUX(A, 3, 1)>; /* TX_CTL */
> like RZ/V2H on RZ/G3E PFC_OEN BITS(0,1) need to be configured based on
> RGMII/MII mode?

Yes, it is the case. OEN1 and OEN0.

> 
> Cheers,
> Prabhakar

Regards,
John

> 
> > +       };
> > +
> > +       eth1_pins: eth1 {
> > +               pinmux = <RZG3E_PORT_PINMUX(D, 1, 1)>, /* MDC */
> > +                        <RZG3E_PORT_PINMUX(D, 0, 1)>, /* MDIO */
> > +                        <RZG3E_PORT_PINMUX(F, 2, 15)>, /* PHY_INTR
> (IRQ15) */
> > +                        <RZG3E_PORT_PINMUX(F, 1, 1)>, /* RXD3 */
> > +                        <RZG3E_PORT_PINMUX(F, 0, 1)>, /* RXD2 */
> > +                        <RZG3E_PORT_PINMUX(E, 7, 1)>, /* RXD1 */
> > +                        <RZG3E_PORT_PINMUX(E, 6, 1)>, /* RXD0 */
> > +                        <RZG3E_PORT_PINMUX(E, 0, 1)>, /* RXC */
> > +                        <RZG3E_PORT_PINMUX(D, 2, 1)>, /* RX_CTL */
> > +                        <RZG3E_PORT_PINMUX(E, 5, 1)>, /* TXD3 */
> > +                        <RZG3E_PORT_PINMUX(E, 4, 1)>, /* TXD2 */
> > +                        <RZG3E_PORT_PINMUX(E, 3, 1)>, /* TXD1 */
> > +                        <RZG3E_PORT_PINMUX(E, 2, 1)>, /* TXD0 */
> > +                        <RZG3E_PORT_PINMUX(E, 1, 1)>, /* TXC */
> > +                        <RZG3E_PORT_PINMUX(D, 3, 1)>; /* TX_CTL */
> > +       };
> > +
> >         i2c2_pins: i2c {
> >                 pinmux = <RZG3E_PORT_PINMUX(3, 4, 1)>, /* SCL2 */
> >                          <RZG3E_PORT_PINMUX(3, 5, 1)>; /* SDA2 */
> > --
> > 2.25.1
> >
> >

  reply	other threads:[~2025-06-19 11:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11  6:16 [PATCH v2 0/3] Add support for GBETH IPs found on RZ/G3E SoCs John Madieu
2025-06-11  6:16 ` [PATCH v2 1/3] clk: renesas: r9a09g047: Add clock and reset signals for the GBETH IPs John Madieu
2025-06-17 15:11   ` Geert Uytterhoeven
2025-06-18 10:04     ` John Madieu
2025-06-18 11:02       ` Geert Uytterhoeven
2025-06-19  4:34         ` John Madieu
2025-06-19  8:21           ` Lad, Prabhakar
2025-06-25 15:18             ` Geert Uytterhoeven
2025-06-30 16:22               ` John Madieu
2025-07-01  8:05                 ` Geert Uytterhoeven
2025-06-11  6:16 ` [PATCH v2 2/3] arm64: dts: renesas: r9a09g047: Add GBETH nodes John Madieu
2025-06-17 15:32   ` Geert Uytterhoeven
2025-06-18  8:54     ` John Madieu
2025-06-11  6:16 ` [PATCH v2 3/3] arm64: dts: renesas: rzg3e-smarc-som: Enable eth{0-1} (GBETH) interfaces John Madieu
2025-06-17 15:50   ` Geert Uytterhoeven
2025-06-18  8:47     ` John Madieu
2025-06-19  8:59   ` Lad, Prabhakar
2025-06-19 11:09     ` John Madieu [this message]
2025-06-12 20:12 ` [PATCH v2 0/3] Add support for GBETH IPs found on RZ/G3E SoCs Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSCPR01MB146474526AD10BFCF587A8F85FF7DA@OSCPR01MB14647.jpnprd01.prod.outlook.com \
    --to=john.madieu.xa@bp.renesas.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=geert+renesas@glider.be \
    --cc=john.madieu@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®