From: John Madieu <john.madieu.xa@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"robh@kernel.org" <robh@kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>,
"Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"john.madieu@gmail.com" <john.madieu@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"magnus.damm@gmail.com" <magnus.damm@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH v2 1/3] clk: renesas: r9a09g047: Add clock and reset signals for the GBETH IPs
Date: Mon, 30 Jun 2025 16:22:56 +0000 [thread overview]
Message-ID: <OSCPR01MB14647AB8B2901DE1EBEB32145FF46A@OSCPR01MB14647.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdXdhYJ7ZKVa_f15PMBv7t1_xsDUuwR+uv+bOaHMxtr8Lg@mail.gmail.com>
Hi Geert,
> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: Wednesday, June 25, 2025 5:19 PM
> To: John Madieu <john.madieu.xa@bp.renesas.com>
> Subject: Re: [PATCH v2 1/3] clk: renesas: r9a09g047: Add clock and reset
> signals for the GBETH IPs
>
> Ho John,
>
> On Thu, 19 Jun 2025 at 10:22, Lad, Prabhakar <prabhakar.csengg@gmail.com>
> wrote:
> > On Thu, Jun 19, 2025 at 5:34 AM John Madieu
> > <john.madieu.xa@bp.renesas.com> wrote:
> > > > From: Geert Uytterhoeven <geert@linux-m68k.org> On Wed, 18 Jun
> > > > 2025 at 12:04, John Madieu <john.madieu.xa@bp.renesas.com>
> > > > wrote:
> > > > > > From: Geert Uytterhoeven <geert@linux-m68k.org> On Wed, 11 Jun
> > > > > > 2025 at 11:02, John Madieu <john.madieu.xa@bp.renesas.com>
> > > > > > wrote:
> > > > > > > Add clock and reset entries for the Gigabit Ethernet
> > > > > > > Interfaces (GBETH
> > > > > > > 0-1) IPs found on the RZ/G3E SoC. This includes various
> > > > > > > PLLs, dividers, and mux clocks needed by these two GBETH IPs.
> > > > > > >
> > > > > > > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > > > > > Tested-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > > > > > Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com>
> > > > > >
> > > > > > Thanks for your patch!
> > > > > >
> > > > > > > --- a/drivers/clk/renesas/r9a09g047-cpg.c
> > > > > > > +++ b/drivers/clk/renesas/r9a09g047-cpg.c
> > > >
> >
> > "The clock gating cells require source clocks to operate correctly. If
> > the source clocks are stopped, these registers cannot be used."
>
> Has this been sorted out yet? I see no change or mention of it in v3.
>
Yes, it has been sorted out. I mean they operated properly after
all the tests, even after S2R/wakeup test.
While at it, even with OEN patches applied, I could not reproduce
the issue known to V2H. That's why I've asked if you'd prefer
DEF_MOD_EXTERNAL instead of DEF_MOD (which does not work on V2H)
for consistency with RZ/V2H, I can do that as well.
>
> Gr{oetje,eeting}s,
>
> Geert
>
Regards,
John
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
next prev parent reply other threads:[~2025-06-30 16:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 6:16 [PATCH v2 0/3] Add support for GBETH IPs found on RZ/G3E SoCs John Madieu
2025-06-11 6:16 ` [PATCH v2 1/3] clk: renesas: r9a09g047: Add clock and reset signals for the GBETH IPs John Madieu
2025-06-17 15:11 ` Geert Uytterhoeven
2025-06-18 10:04 ` John Madieu
2025-06-18 11:02 ` Geert Uytterhoeven
2025-06-19 4:34 ` John Madieu
2025-06-19 8:21 ` Lad, Prabhakar
2025-06-25 15:18 ` Geert Uytterhoeven
2025-06-30 16:22 ` John Madieu [this message]
2025-07-01 8:05 ` Geert Uytterhoeven
2025-06-11 6:16 ` [PATCH v2 2/3] arm64: dts: renesas: r9a09g047: Add GBETH nodes John Madieu
2025-06-17 15:32 ` Geert Uytterhoeven
2025-06-18 8:54 ` John Madieu
2025-06-11 6:16 ` [PATCH v2 3/3] arm64: dts: renesas: rzg3e-smarc-som: Enable eth{0-1} (GBETH) interfaces John Madieu
2025-06-17 15:50 ` Geert Uytterhoeven
2025-06-18 8:47 ` John Madieu
2025-06-19 8:59 ` Lad, Prabhakar
2025-06-19 11:09 ` John Madieu
2025-06-12 20:12 ` [PATCH v2 0/3] Add support for GBETH IPs found on RZ/G3E SoCs Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSCPR01MB14647AB8B2901DE1EBEB32145FF46A@OSCPR01MB14647.jpnprd01.prod.outlook.com \
--to=john.madieu.xa@bp.renesas.com \
--cc=andrew+netdev@lunn.ch \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=geert@linux-m68k.org \
--cc=john.madieu@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®