mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Hawkins, Nick" <nick.hawkins@hpe.com>
To: Guenter Roeck <linux@roeck-us.net>,
	"Verdun, Jean-Marie" <verdun@hpe.com>,
	"Harders, Nick" <nicholas.harders@hpe.com>,
	"joel@jms.id.au" <joel@jms.id.au>,
	"arnd@arndb.de" <arnd@arndb.de>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Subject: RE: [PATCH v4 03/11] drivers: wdt: Introduce HPE GXP SoC Watchdog
Date: Wed, 20 Apr 2022 17:06:11 +0000	[thread overview]
Message-ID: <PH0PR84MB17181ADC802E69F91A583B6488F59@PH0PR84MB1718.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <565f92d7-78d1-7623-4c13-70d49eed5821@roeck-us.net>



-----Original Message-----
From: Guenter Roeck [mailto:groeck7@gmail.com] On Behalf Of Guenter Roeck
Sent: Wednesday, April 20, 2022 10:53 AM
To: Hawkins, Nick <nick.hawkins@hpe.com>; Verdun, Jean-Marie <verdun@hpe.com>; Harders, Nick <nicholas.harders@hpe.com>; joel@jms.id.au; arnd@arndb.de
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>; linux-kernel@vger.kernel.org; linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v4 03/11] drivers: wdt: Introduce HPE GXP SoC Watchdog

On 4/20/22 08:01, nick.hawkins@hpe.com wrote:
> > From: Nick Hawkins <nick.hawkins@hpe.com>
> > 
> > Adding support for the HPE GXP Watchdog. It is new to the linux 
> > community and this along with several other patches is the first 
> > support for it. The GXP asic contains a full compliment of timers one 
> > of which is the watchdog timer. The watchdog timer is 16 bit and has 
> > 10ms resolution. The watchdog is now

>  Drop "now".

I have corrected this.

> > created as a child device of timer since the same register range is 
> > used. This was done due to changes requested with the device tree.
> > 

> Drop last sentence; it is part of the change log and should stay there.

I have corrected this.

> > ---

> Changes made in v3 and v4 are missing.
Fixed, I will fix this on the rest of the patches on this set.
> > +config GXP_WATCHDOG
> > +	tristate "HPE GXP watchdog support"
> > +	depends on ARCH_HPE_GXP
> > +	select WATCHDOG_CORE
> > +	help
> > +	  Say Y here to include support for the watchdog timer
> > +	  in HPE GXP SoCs.
> > +

> Add something like:

> To compile this driver as a module, choose M here: the
> module will be calledgxp_wdt.

This has been changed. I will look through the rest of the other Kconfigs to make sure this statement is there.

Thanks for the feedback,

-Nick Hawkins

  reply	other threads:[~2022-04-20 17:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20 15:01 [PATCH v4 01/11] arch: arm: mach-hpe: Introduce the HPE GXP architecture nick.hawkins
2022-04-20 15:01 ` [PATCH v4 02/11] arch: arm: configs: multi_v7_defconfig nick.hawkins
2022-04-20 15:01 ` [PATCH v4 03/11] drivers: wdt: Introduce HPE GXP SoC Watchdog nick.hawkins
2022-04-20 15:52   ` Guenter Roeck
2022-04-20 17:06     ` Hawkins, Nick [this message]
2022-04-20 15:01 ` [PATCH v4 04/11] clocksource/drivers: Add HPE GXP timer nick.hawkins
2022-04-20 15:01 ` [PATCH v4 05/11] dt-bindings: timer: Add HPE GXP Timer Binding nick.hawkins
2022-04-20 15:01 ` [PATCH v4 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding nick.hawkins
2022-04-20 15:53   ` Guenter Roeck
2022-04-20 16:08     ` Hawkins, Nick
2022-04-20 16:36       ` Guenter Roeck
2022-04-20 17:15         ` Hawkins, Nick
2022-04-20 15:01 ` [PATCH v4 07/11] dt-bindings: arm: Add HPE GXP Binding nick.hawkins
2022-04-20 15:01 ` [PATCH v4 08/11] dt-bindings: usb: generic-echi: Add HPE GXP echi binding nick.hawkins
2022-04-20 15:01 ` [PATCH v4 09/11] dt-bindings: usb: generic-ochi: Add HPE GXP ochi binding nick.hawkins
2022-04-20 17:02   ` Arnd Bergmann
2022-04-20 17:12     ` Hawkins, Nick
2022-04-20 15:01 ` [PATCH v4 10/11] arch: arm: boot: dts: Introduce HPE GXP Device tree nick.hawkins
2022-04-20 15:01 ` [PATCH v4 11/11] maintainers: Introduce HPE GXP Architecture nick.hawkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR84MB17181ADC802E69F91A583B6488F59@PH0PR84MB1718.NAMPRD84.PROD.OUTLOOK.COM \
    --to=nick.hawkins@hpe.com \
    --cc=arnd@arndb.de \
    --cc=joel@jms.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=nicholas.harders@hpe.com \
    --cc=verdun@hpe.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®