mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Hawkins, Nick" <nick.hawkins@hpe.com>,
	"Verdun, Jean-Marie" <verdun@hpe.com>,
	"Harders, Nick" <nicholas.harders@hpe.com>,
	"joel@jms.id.au" <joel@jms.id.au>,
	"arnd@arndb.de" <arnd@arndb.de>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
	Rob Herring <robh+dt@kernel.org>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding
Date: Wed, 20 Apr 2022 09:36:38 -0700	[thread overview]
Message-ID: <d84f994d-e291-84d0-5576-571984cf5018@roeck-us.net> (raw)
In-Reply-To: <PH0PR84MB17181A87E72D66C7F669F90288F59@PH0PR84MB1718.NAMPRD84.PROD.OUTLOOK.COM>

On 4/20/22 09:08, Hawkins, Nick wrote:
> 
> 
> -----Original Message-----
> From: Guenter Roeck [mailto:groeck7@gmail.com] On Behalf Of Guenter Roeck
> Sent: Wednesday, April 20, 2022 10:53 AM
> To: Hawkins, Nick <nick.hawkins@hpe.com>; Verdun, Jean-Marie <verdun@hpe.com>; Harders, Nick <nicholas.harders@hpe.com>; joel@jms.id.au; arnd@arndb.de
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>; Rob Herring <robh+dt@kernel.org>; linux-watchdog@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v4 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding
> 
> On 4/20/22 08:01, nick.hawkins@hpe.com wrote:
>>> From: Nick Hawkins <nick.hawkins@hpe.com>
>>>
>>> Add the hpe gxp watchdog timer binding hpe,gxp-wdt.
>>> This will enable support for the HPE GXP Watchdog
>>>
>>> Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com>
>>>
>>> ---
>>> v2:
> 
>> v3 and v4 changes are missing.
> 
> I considered this the second attempt with a valid patchset but I will change this to v4 and add v3 v2. Should I make a v5 to say I updated the patch message?
> 

Sorry, I can't parse your statement. If there was no change in v3 and v4,
the change log for v3 and v4 should say "no changes in v3 and v4".
If the changes were made in v3 and/or v4, the change log should say that.
If the patch was added in v2/v3/v4, the change log should say that.
Either case, the last version in the change log should match the version
in the subject. Reviewers won't otherwise know how to match the patch
version with the change log. They will have to dig up v1..v3 to compare
the versions and find that out what exactly changed where (and why).
In my case, that commonly translates to "move patch to the end of my
review queue" because I just don't have the time to do that.

Guenter

  reply	other threads:[~2022-04-20 16:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20 15:01 [PATCH v4 01/11] arch: arm: mach-hpe: Introduce the HPE GXP architecture nick.hawkins
2022-04-20 15:01 ` [PATCH v4 02/11] arch: arm: configs: multi_v7_defconfig nick.hawkins
2022-04-20 15:01 ` [PATCH v4 03/11] drivers: wdt: Introduce HPE GXP SoC Watchdog nick.hawkins
2022-04-20 15:52   ` Guenter Roeck
2022-04-20 17:06     ` Hawkins, Nick
2022-04-20 15:01 ` [PATCH v4 04/11] clocksource/drivers: Add HPE GXP timer nick.hawkins
2022-04-20 15:01 ` [PATCH v4 05/11] dt-bindings: timer: Add HPE GXP Timer Binding nick.hawkins
2022-04-20 15:01 ` [PATCH v4 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding nick.hawkins
2022-04-20 15:53   ` Guenter Roeck
2022-04-20 16:08     ` Hawkins, Nick
2022-04-20 16:36       ` Guenter Roeck [this message]
2022-04-20 17:15         ` Hawkins, Nick
2022-04-20 15:01 ` [PATCH v4 07/11] dt-bindings: arm: Add HPE GXP Binding nick.hawkins
2022-04-20 15:01 ` [PATCH v4 08/11] dt-bindings: usb: generic-echi: Add HPE GXP echi binding nick.hawkins
2022-04-20 15:01 ` [PATCH v4 09/11] dt-bindings: usb: generic-ochi: Add HPE GXP ochi binding nick.hawkins
2022-04-20 17:02   ` Arnd Bergmann
2022-04-20 17:12     ` Hawkins, Nick
2022-04-20 15:01 ` [PATCH v4 10/11] arch: arm: boot: dts: Introduce HPE GXP Device tree nick.hawkins
2022-04-20 15:01 ` [PATCH v4 11/11] maintainers: Introduce HPE GXP Architecture nick.hawkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d84f994d-e291-84d0-5576-571984cf5018@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=nicholas.harders@hpe.com \
    --cc=nick.hawkins@hpe.com \
    --cc=robh+dt@kernel.org \
    --cc=verdun@hpe.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®