From: Anandu Padinhare <Anandu.Padinhare@electrifex.com>
To: Thilo Zirnstein <thi.zirnstein@gmail.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@kernel.org" <edumazet@kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v1 1/1] net: phylink: keep initial advertising settings
Date: Mon, 9 Nov 2026 09:58:33 +0000 [thread overview]
Message-ID: <PNYPR01MB1144420346F647D64C23775D2FD732@PNYPR01MB11444.INDPRD01.PROD.OUTLOOK.COM> (raw)
On Wed, Nov 04, 2026 at 01:55:09PM +0100, Thilo Zirnstein wrote:
> Connecting the phy while ndo_open callback seems to be a common pattern,
> affected drivers are:
>
> * macb
> * r8169
> * stmmac
> * tn40xx
Hi Thilo,
Results from an ADSP-SC598 board (stmmac, RGMII, TI DP83867 PHY) with
a 6.18-based kernel, with and without this patch.
1. The case in the commit message is fixed, with both the dp83867 and
the generic PHY driver:
ip link set eth0 down
ethtool -s eth0 speed 100 duplex full autoneg on
ip link set eth0 up
Without the patch the link comes up at 1000 Mb/s; with it, at
100 Mb/s.
2. In that same case the pause bits are lost: with the patch the link
comes up with flow control off; without it, pause stays on. Same
with both PHY drivers. While the interface is down, ethtool shows
no advertised modes and no pause, before and after the
"ethtool -s" (phylink_ethtool_ksettings_get() reports none when no
PHY is attached), and the AND then drops the pause bits the PHY
advertises.
3. Sashiko's sequences (a) and (b) both reproduce with the dp83867
driver:
(a) advertise 100baseT/Full while up, ifdown/ifup: 100 Mb/s.
advertise 10/100/1000baseT/Full while up: 1000 Mb/s.
ifdown/ifup: back to 100 Mb/s, advertising only 100baseT/Full.
(b) continuing, advertise 1000baseT/Full while up: 1000 Mb/s.
ifdown/ifup: "Advertised link modes: Not reported", and the
link stays down (NO-CARRIER).
Without the patch, both keep the last setting: (a) comes back at
1000 Mb/s, and (b) at 1000 Mb/s with 1000baseT/Full advertised.
Happy to test a v2 on this board.
next reply other threads:[~2026-11-09 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 9:58 Anandu Padinhare [this message]
2026-11-19 9:55 ` Thilo Zirnstein
-- strict thread matches above, loose matches on Subject: below --
2026-11-04 12:55 Thilo Zirnstein
2026-11-06 13:51 ` Andrew Lunn
2026-11-06 21:21 ` Thilo Zirnstein
2026-11-08 13:16 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PNYPR01MB1144420346F647D64C23775D2FD732@PNYPR01MB11444.INDPRD01.PROD.OUTLOOK.COM \
--to=anandu.padinhare@electrifex.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thi.zirnstein@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®