mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thilo Zirnstein <thi.zirnstein@gmail.com>
To: Anandu Padinhare <Anandu.Padinhare@electrifex.com>
Cc: "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"andrew@lunn.ch" <andrew@lunn.ch>,
	"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@kernel.org" <edumazet@kernel.org>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v1 1/1] net: phylink: keep initial advertising settings
Date: Thu, 19 Nov 2026 10:55:27 +0100	[thread overview]
Message-ID: <av7Hj_S_B2qSpNsk@thi-server.fritz.box> (raw)
In-Reply-To: <PNYPR01MB1144420346F647D64C23775D2FD732@PNYPR01MB11444.INDPRD01.PROD.OUTLOOK.COM>

On Mon, Nov 09, 2026 at 09:58:33AM +0000, Anandu Padinhare wrote:

Hi Anandu, 

Thanks for testing this nad giving feedback.

...

> Hi Thilo,
> 
> Results from an ADSP-SC598 board (stmmac, RGMII, TI DP83867 PHY) with
> a 6.18-based kernel, with and without this patch.
> 
> 1. The case in the commit message is fixed, with both the dp83867 and
>    the generic PHY driver:
> 
>      ip link set eth0 down
>      ethtool -s eth0 speed 100 duplex full autoneg on
>      ip link set eth0 up
> 
>    Without the patch the link comes up at 1000 Mb/s; with it, at
>    100 Mb/s.
> 
> 2. In that same case the pause bits are lost: with the patch the link
>    comes up with flow control off; without it, pause stays on. Same
>    with both PHY drivers. While the interface is down, ethtool shows
>    no advertised modes and no pause, before and after the
>    "ethtool -s" (phylink_ethtool_ksettings_get() reports none when no
>    PHY is attached), and the AND then drops the pause bits the PHY
>    advertises.
> 
> 3. Sashiko's sequences (a) and (b) both reproduce with the dp83867
>    driver:
> 
>    (a) advertise 100baseT/Full while up, ifdown/ifup: 100 Mb/s.
>        advertise 10/100/1000baseT/Full while up: 1000 Mb/s.
>        ifdown/ifup: back to 100 Mb/s, advertising only 100baseT/Full.
> 
>    (b) continuing, advertise 1000baseT/Full while up: 1000 Mb/s.
>        ifdown/ifup: "Advertised link modes: Not reported", and the
>        link stays down (NO-CARRIER).
> 
>    Without the patch, both keep the last setting: (a) comes back at
>    1000 Mb/s, and (b) at 1000 Mb/s with 1000baseT/Full advertised.
> 
> Happy to test a v2 on this board.

Ack, I have to rethink how a proper solution should look like.
This has some issues.

Kind regards, 

Thilo



  reply	other threads:[~2026-11-19  9:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09  9:58 Anandu Padinhare
2026-11-19  9:55 ` Thilo Zirnstein [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-11-04 12:55 Thilo Zirnstein
2026-11-06 13:51 ` Andrew Lunn
2026-11-06 21:21   ` Thilo Zirnstein
2026-11-08 13:16 ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av7Hj_S_B2qSpNsk@thi-server.fritz.box \
    --to=thi.zirnstein@gmail.com \
    --cc=Anandu.Padinhare@electrifex.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®