From: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>,
"patrick@stwcx.xyz" <patrick@stwcx.xyz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 1/2] ARM: dts: aspeed: greatlakes: Add gpio names
Date: Mon, 10 Apr 2023 07:11:34 +0000 [thread overview]
Message-ID: <PS2PR04MB3592E90B033CA23F47CD02F2B7959@PS2PR04MB3592.apcprd04.prod.outlook.com> (raw)
In-Reply-To: <b66f708c-5369-c1c9-5506-c609a245bf4c@linaro.org>
Thank you for reviewing.
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Wednesday, March 29, 2023 4:37 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> patrick@stwcx.xyz; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley <joel@jms.id.au>; Andrew
> Jeffery <andrew@aj.id.au>
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v1 1/2] ARM: dts: aspeed: greatlakes: Add gpio names
>
> Security Reminder: Please be aware that this email is sent by an external
> sender.
>
> On 29/03/2023 10:32, Delphine CC Chiu wrote:
> > From: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
> >
> > Add GPIO names for SOC lines.
> >
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
> > ---
> > .../dts/aspeed-bmc-facebook-greatlakes.dts | 49
> +++++++++++++++++++
> > 1 file changed, 49 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
> > b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
> > index 8c05bd56ce1e..59819115c39d 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
> > @@ -238,4 +238,53 @@
> > &gpio0 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_gpiu1_default &pinctrl_gpiu7_default>;
> > + status = "okay";
>
> Was it disabled before?
>
Yes, we have to enable gpio status for meeting aspeed-g6 device tree setting, and set net names for pulling gpio pin from application layer.
> > + gpio-line-names =
> > + /*A0-A7*/ "","","","","","","","",
> > + /*B0-B7*/ "power-bmc-nic","presence-ocp-debug",
> > + "power-bmc-slot1","power-bmc-slot2",
> > + "power-bmc-slot3","power-bmc-slot4","","",
> > + /*C0-C7*/ "presence-ocp-nic","","","reset-cause-nic-primary",
> > + "reset-cause-nic-secondary","","","",
> > + /*D0-D7*/ "","","","","","","","",
> > + /*E0-E7*/ "","","","","","","","",
> > + /*F0-F7*/ "slot1-bmc-reset-button","slot2-bmc-reset-button",
> > + "slot3-bmc-reset-button","slot4-bmc-reset-button",
> > + "","","","presence-emmc",
> > + /*G0-G7*/ "","","","","","","","",
> > + /*H0-H7*/ "","","","",
> > + "presence-mb-slot1","presence-mb-slot2",
> > + "presence-mb-slot3","presence-mb-slot4",
> > + /*I0-I7*/ "","","","","","","bb-bmc-button","",
> > + /*J0-J7*/ "","","","","","","","",
> > + /*K0-K7*/ "","","","","","","","",
> > + /*L0-L7*/ "","","","","","","","",
> > + /*M0-M7*/
> "","power-nic-bmc-enable","","usb-bmc-enable","","reset-cause-usb-hub","","",
> > + /*N0-N7*/ "","","","","bmc-ready","","","",
> > + /*O0-O7*/
> "","","","","","","fan0-bmc-cpld-enable","fan1-bmc-cpld-enable",
> > + /*P0-P7*/ "fan2-bmc-cpld-enable","fan3-bmc-cpld-enable",
> > + "reset-cause-pcie-slot1","reset-cause-pcie-slot2",
> > + "reset-cause-pcie-slot3","reset-cause-pcie-slot4","","",
> > + /*Q0-Q7*/ "","","","","","","","",
> > + /*R0-R7*/ "","","","","","","","",
> > + /*S0-S7*/ "","","power-p5v-usb","presence-bmc-tpm","","","","",
> > + /*T0-T7*/ "","","","","","","","",
> > + /*U0-U7*/ "","","","","","","","GND",
> > + /*V0-V7*/ "bmc-slot1-ac-button","bmc-slot2-ac-button",
> > + "bmc-slot3-ac-button","bmc-slot4-ac-button",
> > + "","","","",
> > + /*W0-W7*/ "","","","","","","","",
> > + /*X0-X7*/ "","","","","","","","",
> > + /*Y0-Y7*/ "","","","reset-cause-emmc","","","","",
> > + /*Z0-Z7*/ "","","","","","","",""; };
> > +
> > +&gpio1 {
> > + status = "okay";
>
> Same question...
Yes, the answer is same as above.
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2023-04-10 7:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 8:32 [PATCH v1 0/2] dts: aspeed: greatlakes: Update Greatlakes devicetree Delphine CC Chiu
2023-03-29 8:32 ` [PATCH v1 1/2] ARM: dts: aspeed: greatlakes: Add gpio names Delphine CC Chiu
2023-03-29 8:36 ` Krzysztof Kozlowski
2023-04-10 7:11 ` Delphine_CC_Chiu/WYHQ/Wiwynn [this message]
2023-04-10 15:21 ` Krzysztof Kozlowski
2023-04-24 9:50 ` Delphine_CC_Chiu/WYHQ/Wiwynn
2023-03-29 8:32 ` [PATCH v1 2/2] ARM: dts: aspeed: greatlakes: add mctp device Delphine CC Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PS2PR04MB3592E90B033CA23F47CD02F2B7959@PS2PR04MB3592.apcprd04.prod.outlook.com \
--to=delphine_cc_chiu@wiwynn.com \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®