From: Bert Wesarg <wesarg@informatik.uni-halle.de>
To: Gerd Knorr <kraxel@bytesex.org>
Cc: video4linux-list@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH] fix module_param_string() calls
Date: Sun, 27 Mar 2005 14:58:27 +0200 (MEST) [thread overview]
Message-ID: <Pine.GSO.4.56.0503271457280.25037@turing> (raw)
Hello,
this patch fix 3 calls to module_param_string() in
driver/media/video/tuner-core.c and drivers/media/video/tda9887.c.
In all three places, the len and the perm parameter was switched.
Patch is against 2.6.12-rc1.
Signed-off-by: Bert Wesarg <wesarg@informatik.uni-halle.de>
diff -uprN linux-2.6.12-rc1.orig/drivers/media/video/tda9887.c linux-2.6.12-rc1/drivers/media/video/tda9887.c
--- linux-2.6.12-rc1.orig/drivers/media/video/tda9887.c 2005-03-27 14:44:23.000000000 +0200
+++ linux-2.6.12-rc1/drivers/media/video/tda9887.c 2005-03-27 14:48:06.000000000 +0200
@@ -478,9 +478,9 @@ static int tda9887_set_pinnacle(struct t
/* ---------------------------------------------------------------------- */
static char pal[] = "-";
-module_param_string(pal, pal, 0644, sizeof(pal));
+module_param_string(pal, pal, sizeof(pal), 0644);
static char secam[] = "-";
-module_param_string(secam, secam, 0644, sizeof(secam));
+module_param_string(secam, secam, sizeof(secam), 0644);
static int tda9887_fixup_std(struct tda9887 *t)
{
diff -uprN linux-2.6.12-rc1.orig/drivers/media/video/tuner-core.c linux-2.6.12-rc1/drivers/media/video/tuner-core.c
--- linux-2.6.12-rc1.orig/drivers/media/video/tuner-core.c 2005-03-27 14:44:23.000000000 +0200
+++ linux-2.6.12-rc1/drivers/media/video/tuner-core.c 2005-03-27 14:47:17.000000000 +0200
@@ -162,7 +162,7 @@ static void set_type(struct i2c_client *
}
static char pal[] = "-";
-module_param_string(pal, pal, 0644, sizeof(pal));
+module_param_string(pal, pal, sizeof(pal), 0644);
static int tuner_fixup_std(struct tuner *t)
{
reply other threads:[~2005-03-27 12:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.56.0503271457280.25037@turing \
--to=wesarg@informatik.uni-halle.de \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®