mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] fix module_param_string() calls
@ 2005-03-27 12:58 Bert Wesarg
  0 siblings, 0 replies; only message in thread
From: Bert Wesarg @ 2005-03-27 12:58 UTC (permalink / raw)
  To: Gerd Knorr; +Cc: video4linux-list, linux-kernel

Hello,

this patch fix 3 calls to module_param_string() in
driver/media/video/tuner-core.c and drivers/media/video/tda9887.c.
In all three places, the len and the perm parameter was switched.

Patch is against 2.6.12-rc1.

Signed-off-by: Bert Wesarg <wesarg@informatik.uni-halle.de>

diff -uprN linux-2.6.12-rc1.orig/drivers/media/video/tda9887.c linux-2.6.12-rc1/drivers/media/video/tda9887.c
--- linux-2.6.12-rc1.orig/drivers/media/video/tda9887.c	2005-03-27 14:44:23.000000000 +0200
+++ linux-2.6.12-rc1/drivers/media/video/tda9887.c	2005-03-27 14:48:06.000000000 +0200
@@ -478,9 +478,9 @@ static int tda9887_set_pinnacle(struct t
 /* ---------------------------------------------------------------------- */

 static char pal[] = "-";
-module_param_string(pal, pal, 0644, sizeof(pal));
+module_param_string(pal, pal, sizeof(pal), 0644);
 static char secam[] = "-";
-module_param_string(secam, secam, 0644, sizeof(secam));
+module_param_string(secam, secam, sizeof(secam), 0644);

 static int tda9887_fixup_std(struct tda9887 *t)
 {
diff -uprN linux-2.6.12-rc1.orig/drivers/media/video/tuner-core.c linux-2.6.12-rc1/drivers/media/video/tuner-core.c
--- linux-2.6.12-rc1.orig/drivers/media/video/tuner-core.c	2005-03-27 14:44:23.000000000 +0200
+++ linux-2.6.12-rc1/drivers/media/video/tuner-core.c	2005-03-27 14:47:17.000000000 +0200
@@ -162,7 +162,7 @@ static void set_type(struct i2c_client *
 }

 static char pal[] = "-";
-module_param_string(pal, pal, 0644, sizeof(pal));
+module_param_string(pal, pal, sizeof(pal), 0644);

 static int tuner_fixup_std(struct tuner *t)
 {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-03-27 12:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-03-27 12:58 [PATCH] fix module_param_string() calls Bert Wesarg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®