mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Benedyczak <golbi@mat.uni.torun.pl>
To: linux-kernel@vger.kernel.org
Cc: torvalds@osdl.org, Michael Kerrisk <michael.kerrisk@gmx.net>,
	Michal Wronski <michal.wronski@gmail.com>
Subject: [PATCH] umask in POSIX message queues
Date: Mon, 26 Sep 2005 12:44:24 +0200 (CEST)	[thread overview]
Message-ID: <Pine.GSO.4.58.0509261218080.5216@Juliusz> (raw)

Hi

All kernels (form 2.6.6) ignore umask when creating new queues via
mq_open (when creating with open() on mqueue fs it is ok of course).
According to specification this a bug. The following trivial patch fixes
this. It should apply cleanly to any current kernel. Please apply.


Signed-off-by: Krzysztof Benedyczak <golbi@mat.uni.torun.pl>


--- linux-2.6.14-rc2/ipc/mqueue.c.orig  2005-09-25 18:52:29.000000000 +0200
+++ linux-2.6.14-rc2/ipc/mqueue.c       2005-09-26 11:44:41.000000000 +0200
@@ -278,6 +278,8 @@ static int mqueue_create(struct inode *d
        queues_count++;
        spin_unlock(&mq_lock);

+       mode &= ~current->fs->umask;
+
        inode = mqueue_get_inode(dir->i_sb, mode, attr);
        if (!inode) {
                error = -ENOMEM;


             reply	other threads:[~2005-09-26 10:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-26 10:44 Krzysztof Benedyczak [this message]
2005-09-27  1:29 ` Linus Torvalds
2005-09-27 11:13   ` Krzysztof Benedyczak
2005-09-27 14:55     ` Linus Torvalds
2005-09-27 20:21       ` Krzysztof Benedyczak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.GSO.4.58.0509261218080.5216@Juliusz \
    --to=golbi@mat.uni.torun.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.kerrisk@gmx.net \
    --cc=michal.wronski@gmail.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®