From: Linus Torvalds <torvalds@osdl.org>
To: Krzysztof Benedyczak <golbi@mat.uni.torun.pl>
Cc: linux-kernel@vger.kernel.org,
Michael Kerrisk <michael.kerrisk@gmx.net>,
Michal Wronski <michal.wronski@gmail.com>
Subject: Re: [PATCH] umask in POSIX message queues
Date: Mon, 26 Sep 2005 18:29:19 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0509261827150.3308@g5.osdl.org> (raw)
In-Reply-To: <Pine.GSO.4.58.0509261218080.5216@Juliusz>
On Mon, 26 Sep 2005, Krzysztof Benedyczak wrote:
>
> All kernels (form 2.6.6) ignore umask when creating new queues via
> mq_open (when creating with open() on mqueue fs it is ok of course).
> According to specification this a bug. The following trivial patch fixes
> this. It should apply cleanly to any current kernel. Please apply.
As far as I can tell, the VFS layer should have done this for us already,
with code like
...
if (!IS_POSIXACL(dir->d_inode))
mode &= ~current->fs->umask;
error = vfs_create(dir->d_inode, path.dentry, mode, nd);
...
in fs/namei.c (open_namei()).
Which path did you come through that didn't do this? That would be the
real bug, I suspect..
Linus
next prev parent reply other threads:[~2005-09-27 1:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-26 10:44 Krzysztof Benedyczak
2005-09-27 1:29 ` Linus Torvalds [this message]
2005-09-27 11:13 ` Krzysztof Benedyczak
2005-09-27 14:55 ` Linus Torvalds
2005-09-27 20:21 ` Krzysztof Benedyczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0509261827150.3308@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=golbi@mat.uni.torun.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.kerrisk@gmx.net \
--cc=michal.wronski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®