From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>,
Roman Zippel <zippel@linux-m68k.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 504] m68k: smp_lock.h: Avoid recursive include
Date: Mon, 1 Nov 2004 21:21:43 +0100 (MET) [thread overview]
Message-ID: <Pine.GSO.4.61.0411012117330.8299@waterleaf.sonytel.be> (raw)
In-Reply-To: <Pine.LNX.4.58.0410311612140.17101@ppc970.osdl.org>
On Sun, 31 Oct 2004, Linus Torvalds wrote:
> Not only is that include not recursive, but it immediately breaks any SMP
It's not immediately recursive, but <linux/sched.h> includes about everything
and the kitchen sink, causing fatal problems on m68k since 2.6.9*...
> compile because that header file _needs_ the definition of "task_struct".
Sorry, forgot about SMP.
So we have to move the definition of "task_struct" to <linux/task_struct.h>
first, to avoid include hell. Cfr. what Roman Zippel is working on.
> I applied it without realizing it, but I'll undo it and I hope you fix
> your broken tree so that I don't ever have to see this broken patch
> again..
Don't worry, it has been moved to my POSTPONED queue :-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2004-11-02 5:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-31 10:03 [PATCH 504] " Geert Uytterhoeven
2004-11-01 0:13 ` [PATCH 504] m68k: " Linus Torvalds
2004-11-01 20:21 ` Geert Uytterhoeven [this message]
2004-11-02 7:46 Chuck Ebbert
2004-11-02 8:25 ` Geert Uytterhoeven
2004-11-02 21:28 ` Geert Uytterhoeven
2004-11-04 0:10 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.61.0411012117330.8299@waterleaf.sonytel.be \
--to=geert@linux-m68k.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®