From: Linus Torvalds <torvalds@osdl.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 504] m68k: smp_lock.h: Avoid recursive include
Date: Sun, 31 Oct 2004 16:13:29 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.58.0410311612140.17101@ppc970.osdl.org> (raw)
In-Reply-To: <200410311003.i9VA3d14009637@anakin.of.borg>
This one is _totally_ broken.
Not only is that include not recursive, but it immediately breaks any SMP
compile because that header file _needs_ the definition of "task_struct".
I applied it without realizing it, but I'll undo it and I hope you fix
your broken tree so that I don't ever have to see this broken patch
again..
Linus
On Sun, 31 Oct 2004, Geert Uytterhoeven wrote:
>
> smp_lock.h: Avoid recursive include
>
> Signed-off-by: Roman Zippel <zippel@linux-m68k.org>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
>
> --- linux-2.6.10-rc1/include/linux/smp_lock.h 2004-04-28 15:47:31.000000000 +0200
> +++ linux-m68k-2.6.10-rc1/include/linux/smp_lock.h 2004-10-20 22:24:05.000000000 +0200
> @@ -2,7 +2,6 @@
> #define __LINUX_SMPLOCK_H
>
> #include <linux/config.h>
> -#include <linux/sched.h>
> #include <linux/spinlock.h>
>
> #if defined(CONFIG_SMP) || defined(CONFIG_PREEMPT)
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
next prev parent reply other threads:[~2004-11-01 0:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-31 10:03 [PATCH 504] " Geert Uytterhoeven
2004-11-01 0:13 ` Linus Torvalds [this message]
2004-11-01 20:21 ` [PATCH 504] m68k: " Geert Uytterhoeven
2004-11-02 7:46 Chuck Ebbert
2004-11-02 8:25 ` Geert Uytterhoeven
2004-11-02 21:28 ` Geert Uytterhoeven
2004-11-04 0:10 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0410311612140.17101@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®