From: Roman Zippel <zippel@linux-m68k.org>
To: Richard Gooch <rgooch@ras.ucalgary.ca>
Cc: Greg KH <greg@kroah.com>, Linus Torvalds <torvalds@transmeta.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [BK PATCH] devfs cleanups for 2.5.29
Date: Wed, 31 Jul 2002 11:32:36 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.44.0207311109560.28515-100000@serv> (raw)
In-Reply-To: <200207310032.g6V0WmW12258@vindaloo.ras.ucalgary.ca>
Hi,
On Tue, 30 Jul 2002, Richard Gooch wrote:
> > Are you sure it's save in devfs_open() too?
>
> Yes. RTFS.
I'm trying - without getting headache.
In the "devfs=only" case, where is the module count incremented, when a
block device is opened?
> > Even if it's save/fixed, it's still code duplication.
>
> No. I leverage fops_get(), a common function.
Which is also insufficiently protected.
Why do you insist on storing the ops pointer in devfs? As long as devfs is
an option, that pointer must be managed at two places.
bye, Roman
next prev parent reply other threads:[~2002-07-31 9:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-30 22:54 Greg KH
2002-07-30 22:54 ` Greg KH
2002-07-30 22:55 ` Greg KH
2002-07-30 23:12 ` Richard Gooch
2002-07-30 23:18 ` Greg KH
2002-07-30 23:46 ` Greg KH
2002-07-30 23:35 ` Roman Zippel
2002-07-30 23:41 ` Richard Gooch
2002-07-31 0:31 ` Roman Zippel
2002-07-31 0:32 ` Richard Gooch
2002-07-31 9:32 ` Roman Zippel [this message]
2002-08-05 22:12 ` Richard Gooch
2002-08-05 22:48 ` Roman Zippel
2002-08-19 0:48 ` Richard Gooch
2002-08-19 9:37 ` Roman Zippel
2002-08-20 17:00 ` Richard Gooch
2002-08-20 17:29 ` Roman Zippel
2002-08-21 4:01 ` Richard Gooch
2002-08-21 11:22 ` Roman Zippel
2002-07-31 20:30 ` Marcin Dalecki
2002-08-01 9:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0207311109560.28515-100000@serv \
--to=zippel@linux-m68k.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rgooch@ras.ucalgary.ca \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®