mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roman Zippel <zippel@linux-m68k.org>
To: Richard Gooch <rgooch@ras.ucalgary.ca>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BK PATCH] devfs cleanups for 2.5.29
Date: Mon, 19 Aug 2002 11:37:43 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.44.0208191121530.28515-100000@serv> (raw)
In-Reply-To: <200208190048.g7J0mGW12548@vindaloo.ras.ucalgary.ca>

Hi,

On Sun, 18 Aug 2002, Richard Gooch wrote:

> > > > In the "devfs=only" case, where is the module count incremented, when a
> > > > block device is opened?
>
> I've already told you about fops_get(). And for a block device, it's
> def_blk_fops.open().

Which basically calls block_dev.c:do_open() and the module count there is
only incremented if get_blkfops() is successfull, which is a dummy in this
case. So where again is the module count incremented?

> I've fixed that in my tree,
> by using devfs_get_ops(), which safely handles this. I've also added
> some comments, to make it clearer.

You never answered my question, why you insist on managing the ops
pointer. The far easier fix would be to simply remove this nonsense.

bye, Roman


  reply	other threads:[~2002-08-19  9:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-30 22:54 Greg KH
2002-07-30 22:54 ` Greg KH
2002-07-30 22:55   ` Greg KH
2002-07-30 23:12 ` Richard Gooch
2002-07-30 23:18   ` Greg KH
2002-07-30 23:46     ` Greg KH
2002-07-30 23:35   ` Roman Zippel
2002-07-30 23:41     ` Richard Gooch
2002-07-31  0:31       ` Roman Zippel
2002-07-31  0:32         ` Richard Gooch
2002-07-31  9:32           ` Roman Zippel
2002-08-05 22:12             ` Richard Gooch
2002-08-05 22:48               ` Roman Zippel
2002-08-19  0:48                 ` Richard Gooch
2002-08-19  9:37                   ` Roman Zippel [this message]
2002-08-20 17:00                     ` Richard Gooch
2002-08-20 17:29                       ` Roman Zippel
2002-08-21  4:01                         ` Richard Gooch
2002-08-21 11:22                           ` Roman Zippel
2002-07-31 20:30 ` Marcin Dalecki
2002-08-01  9:57   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0208191121530.28515-100000@serv \
    --to=zippel@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rgooch@ras.ucalgary.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®