From: Roman Zippel <zippel@linux-m68k.org>
To: Andries.Brouwer@cwi.nl
Cc: B.Zolnierkiewicz@elka.pw.edu.pl, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix error return get/set_native_max functions
Date: Wed, 6 Aug 2003 01:15:00 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.44.0308060058120.717-100000@serv> (raw)
In-Reply-To: <UTC200308052008.h75K8aD22137.aeb@smtp.cwi.nl>
Hi,
On Tue, 5 Aug 2003 Andries.Brouwer@cwi.nl wrote:
> > This change is okay, thanks.
> > However changing coding style is not...
>
> An interesting remark.
>
> I belong to the people who look at kernel source on a screen
> with 80 columns. Code that is wider and wraps is unreadable.
Get a better editor?
While I think 80 columns is a worthwhile goal, I don't see a good reason
to wrap a random line only because it exceeds the limit by a few
characters. What is especially annoying are patches with a one line fix
hidden within 10 other formatting changes (I've seen this already from
you). Please respect others people code and try to avoid randoming
formatting changes or at least keep them separate.
bye, Roman
next prev parent reply other threads:[~2003-08-05 23:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-05 20:08 Andries.Brouwer
2003-08-05 20:45 ` Bartlomiej Zolnierkiewicz
2003-08-05 23:15 ` Roman Zippel [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-08-06 7:09 Andries.Brouwer
2003-08-05 20:27 Andries.Brouwer
2003-08-05 20:57 ` Bartlomiej Zolnierkiewicz
2003-08-05 18:18 Andries.Brouwer
2003-08-05 18:54 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0308060058120.717-100000@serv \
--to=zippel@linux-m68k.org \
--cc=Andries.Brouwer@cwi.nl \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®