mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kumar Gala <galak@gate.crashing.org>
To: dbrownell@users.sourceforge.net
Cc: Randy Vinson <rvinson@mvista.com>, <linux-kernel@vger.kernel.org>,
	<linux-usb-devel@lists.sourceforge.net>
Subject: [PATCH] USB: Fix masking bug initialization of Freescale EHCI controller
Date: Mon, 23 Jan 2006 13:48:21 -0600 (CST)	[thread overview]
Message-ID: <Pine.LNX.4.44.0601231346470.16800-100000@gate.crashing.org> (raw)

In setting up the of PHY we masked off too many bits, instead just
initialize PORTSC for the type of PHY we are using.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

---
commit 2497a5e4242d500178d6d0f0ce4ee9249a38f5dc
tree 71f036ecd23dffb224963b4aabe4f857ba99845b
parent fe49a3f53c2572bf26a9dfd77e54fda1aa853887
author Kumar Gala <galak@kernel.crashing.org> Mon, 23 Jan 2006 13:53:09 -0600
committer Kumar Gala <galak@kernel.crashing.org> Mon, 23 Jan 2006 13:53:09 -0600

 drivers/usb/host/ehci-fsl.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index 6d82054..f40ee41 100644
--- a/drivers/usb/host/ehci-fsl.c
+++ b/drivers/usb/host/ehci-fsl.c
@@ -160,8 +160,7 @@ static void mpc83xx_setup_phy(struct ehc
 			      enum fsl_usb2_phy_modes phy_mode,
 			      unsigned int port_offset)
 {
-	u32 portsc = readl(&ehci->regs->port_status[port_offset]);
-	portsc &= ~PORT_PTS_MSK;
+	u32 portsc = 0;
 	switch (phy_mode) {
 	case FSL_USB2_PHY_ULPI:
 		portsc |= PORT_PTS_ULPI;


             reply	other threads:[~2006-01-23 19:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-23 19:48 Kumar Gala [this message]
2006-01-24 16:11 ` [linux-usb-devel] " David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0601231346470.16800-100000@gate.crashing.org \
    --to=galak@gate.crashing.org \
    --cc=dbrownell@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=rvinson@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®