Re: [linux-usb-devel] [PATCH] USB: Fix masking bug initialization of Freescale EHCI controller

[David Brownell <david-b@pacbell.net>]

On Monday 23 January 2006 11:48 am, Kumar Gala wrote:
> In setting up the of PHY we masked off too many bits, instead just
> initialize PORTSC for the type of PHY we are using.
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

Acked-by: David Brownell <dbrownell@users.sourceforge.net>

> ---
> commit 2497a5e4242d500178d6d0f0ce4ee9249a38f5dc
> tree 71f036ecd23dffb224963b4aabe4f857ba99845b
> parent fe49a3f53c2572bf26a9dfd77e54fda1aa853887
> author Kumar Gala <galak@kernel.crashing.org> Mon, 23 Jan 2006 13:53:09 -0600
> committer Kumar Gala <galak@kernel.crashing.org> Mon, 23 Jan 2006 13:53:09 -0600
> 
>  drivers/usb/host/ehci-fsl.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index 6d82054..f40ee41 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -160,8 +160,7 @@ static void mpc83xx_setup_phy(struct ehc
>  			      enum fsl_usb2_phy_modes phy_mode,
>  			      unsigned int port_offset)
>  {
> -	u32 portsc = readl(&ehci->regs->port_status[port_offset]);
> -	portsc &= ~PORT_PTS_MSK;
> +	u32 portsc = 0;
>  	switch (phy_mode) {
>  	case FSL_USB2_PHY_ULPI:
>  		portsc |= PORT_PTS_ULPI;
> 
> 
>