From: Pavel Roskin <proski@gnu.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Horst von Brand <vonbrand@inf.utfsm.cl>
Subject: [PATCH] mkdep patch in 2.4.21-pre4-ac7 breaks pci/drivers
Date: Mon, 03 Mar 2003 04:00:54 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.51.0303030347020.26129@localhost.localdomain> (raw)
In-Reply-To: <200303020213.h222DM7O003304@eeyore.valparaiso.cl>
Hello!
This patch works for me and doesn't require any changes in mkdep. I
believe it's the right thing to do. The rule for names.o already exists
in the Makefile. The only problem with it is that it's misplaced - it
should precede the generated dependencies.
GNU make just concatenates the lists of dependencies and tries to create
the dependencies in the order is which they appear in the makefile. If
devlist.h without path is first, then make will create it because there is
a rule for that. Thn make will see that devlist.h with path is already
up-to-date.
On the other hand, if devlist.h with path is first, then make won't know
how to create it and will abort rather than go to the next target.
This patch has been tested and works for me. How to test:
make oldconfig
make clean
make depend
make bzImage
make depend
make clean
make bzImage
It works fine now. Patch:
==============================
--- linux.orig/drivers/pci/Makefile
+++ linux/drivers/pci/Makefile
@@ -35,10 +35,10 @@
obj-y += syscall.o
endif
-include $(TOPDIR)/Rules.make
-
names.o: names.c devlist.h classlist.h
+include $(TOPDIR)/Rules.make
+
devlist.h classlist.h: pci.ids gen-devlist
./gen-devlist <pci.ids
==============================
The patch fixes the problem in Alan's 2.4 series, but it can be safely
applied to the Marcelo's 2.4 branch as well.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2003-03-03 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-28 22:00 Pavel Roskin
2003-03-02 2:13 ` Horst von Brand
2003-03-03 8:32 ` Pavel Roskin
2003-03-04 1:27 ` Horst von Brand
2003-03-03 9:00 ` Pavel Roskin [this message]
2003-03-03 9:58 ` [PATCH] " Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.51.0303030347020.26129@localhost.localdomain \
--to=proski@gnu.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vonbrand@inf.utfsm.cl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®