mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Horst von Brand <vonbrand@inf.utfsm.cl>
Subject: Re: [PATCH] mkdep patch in 2.4.21-pre4-ac7 breaks pci/drivers
Date: Mon, 03 Mar 2003 04:58:19 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.51.0303030444310.17059@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.51.0303030347020.26129@localhost.localdomain>

Hello!

> This patch has been tested and works for me.  How to test:

I'm terribly sorry, my testing was incorrect (I was looking at a wrong
window).  One more change needs to be done.  Since name.o becomes the
first rule, it becomes the default rule instead of driver.o, which is not
created.

The trick (already used in drivers/net/hamradio/soundmodem/Makefile) is to
define the first rule as

all: all_targets

Fixed patch:

===================================
--- linux.orig/drivers/pci/Makefile
+++ linux/drivers/pci/Makefile
@@ -35,10 +35,11 @@
 obj-y += syscall.o
 endif

-include $(TOPDIR)/Rules.make
-
+all: all_targets
 names.o: names.c devlist.h classlist.h

+include $(TOPDIR)/Rules.make
+
 devlist.h classlist.h: pci.ids gen-devlist
 	./gen-devlist <pci.ids

===================================

This patch was tested all the way to "make install" and reboot.

-- 
Regards,
Pavel Roskin

      reply	other threads:[~2003-03-03  9:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-28 22:00 Pavel Roskin
2003-03-02  2:13 ` Horst von Brand
2003-03-03  8:32   ` Pavel Roskin
2003-03-04  1:27     ` Horst von Brand
2003-03-03  9:00   ` [PATCH] " Pavel Roskin
2003-03-03  9:58     ` Pavel Roskin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.51.0303030444310.17059@localhost.localdomain \
    --to=proski@gnu.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vonbrand@inf.utfsm.cl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®