From: Davide Libenzi <davidel@xmailserver.org>
To: "Richard B. Johnson" <root@chaos.analogic.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Coding standards. (Was: Re: [PATCH] [2.5] Non-blocking write can block)
Date: Mon, 9 Jun 2003 11:07:32 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.55.0306091101260.3614@bigblue.dev.mcafeelabs.com> (raw)
In-Reply-To: <Pine.LNX.4.53.0306091346150.226@chaos>
yOn Mon, 9 Jun 2003, Richard B. Johnson wrote:
> Last I looked, we had a good example in the Buslogic SCSI driver.
> However, just in case it's been changed, I submit herewith an
> example of real code written by a "professional".
You know why the code you reported is *wrong* (besides from how
techincally do things) ? Mixing lower and upper case, using long variable
and function names, etc... are simply a matter of personal taste and you
cannot say that such code is "absolutely" wrong. The code is damn wrong
because it violates about 25 sections of the project's defined CodingStyle
document, that's why it is wrong.
- Davide
next prev parent reply other threads:[~2003-06-09 17:55 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-04 0:58 [PATCH] [2.5] Non-blocking write can block P. Benie
2003-06-04 5:53 ` Christoph Hellwig
2003-06-04 14:35 ` Linus Torvalds
2003-06-04 14:58 ` P. Benie
2003-06-04 16:47 ` Alan Cox
2003-06-04 17:57 ` Linus Torvalds
2003-06-04 19:46 ` P. Benie
2003-06-04 19:56 ` Linus Torvalds
2003-06-04 20:48 ` P. Benie
2003-06-11 0:19 ` Robert White
2003-06-04 20:43 ` Hua Zhong
2003-06-04 23:42 ` Russell King
2003-06-04 23:47 ` Davide Libenzi
2003-06-04 21:29 ` Alan Cox
2003-06-04 17:14 ` Hua Zhong
2003-06-04 17:41 ` Linus Torvalds
2003-06-04 18:44 ` Hua Zhong
2003-06-04 18:47 ` P. Benie
2003-06-04 19:23 ` P. Benie
2003-06-04 19:20 ` Linus Torvalds
2003-06-04 17:53 ` Mike Dresser
2003-06-04 15:21 ` Coding standards. (Was: Re: [PATCH] [2.5] Non-blocking write can block) Timothy Miller
2003-06-07 0:12 ` Greg KH
2003-06-07 0:59 ` Alex Goddard
2003-06-09 16:24 ` Timothy Miller
2003-06-09 16:39 ` Jörn Engel
2003-06-09 17:15 ` Davide Libenzi
2003-06-09 17:33 ` Eli Carter
2003-06-09 17:49 ` Richard B. Johnson
2003-06-09 18:07 ` Davide Libenzi [this message]
2003-06-09 18:22 ` Jörn Engel
2003-06-09 18:55 ` Timothy Miller
2003-06-09 18:58 ` Davide Libenzi
2003-06-09 21:35 ` David Schwartz
2003-06-09 22:55 ` Davide Libenzi
2003-06-09 23:21 ` Nigel Cunningham
2003-06-09 21:54 ` Jörn Engel
2003-06-10 18:17 ` Jesse Pollard
2003-06-10 18:41 ` Davide Libenzi
2003-06-10 18:14 ` Jesse Pollard
2003-06-09 23:50 ` James Stevenson
2003-06-09 18:44 ` Timothy Miller
2003-06-09 22:00 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.55.0306091101260.3614@bigblue.dev.mcafeelabs.com \
--to=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
--cc=root@chaos.analogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®