Re: 2.4.26-pre1: SCTP compile error

[Sridhar Samudrala <sri@us.ibm.com>]

On Thu, 26 Feb 2004, Adrian Bunk wrote:

> On Wed, Feb 25, 2004 at 04:09:20PM -0300, Marcelo Tosatti wrote:
> >...
> > It contains a big SCTP merge (to match 2.6 API), networking updates,
> >...
>
> I got the compile error forwarded below using gcc 2.95.3 .
>
> cu
> Adrian
>
>
>
> ...
> gcc-2.95 -D__KERNEL__ -I/home/bunk/linux/kernel-2.4/linux-2.4.26-pre1-full/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4   -nostdinc -iwithprefix include -DKBUILD_BASENAME=ipv6  -c -o ipv6.o ipv6.c
> In file included from ipv6.c:77:
> /home/bunk/linux/kernel-2.4/linux-2.4.26-pre1-full/include/net/sctp/sctp.h:119: warning: `MSECS_TO_JIFFIES' redefined
> /home/bunk/linux/kernel-2.4/linux-2.4.26-pre1-full/include/net/irda/irda.h:89: warning: this is the location of the previous definition

I missed this warning as i don't have irda enabled in my config.
A simple fix would be to rename the macro in sctp.h to
SCTP_MSECS_TO_JIFFIES.

> ipv6.c: In function `sctp_v6_xmit':
> ipv6.c:189: request for member `in6_u' in something not a structure or union
> ipv6.c:189: request for member `in6_u' in something not a structure or union

I am not seeing these errors with either gcc3.2.2 or gcc2.96. But, looking at the
code, this definitely seems to be a problem. Not sure why the newer versions of
gcc didn't catch them.

looks like while backporting from 2.6, i missed the fact that in 2.4, fl6_src,
fl6_dst in struct flowi are pointers to struct in6_addr.

I will work on a patch to fix these issues shortly.

Thanks
Sridhar