mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Airlie <airlied@linux.ie>
To: Greg KH <greg@kroah.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dri-devel@lists.sf.net
Subject: Re: From Eric Anholt:
Date: Wed, 12 May 2004 00:20:51 +0100 (IST)	[thread overview]
Message-ID: <Pine.LNX.4.58.0405120018360.3826@skynet> (raw)
In-Reply-To: <20040511222245.GA25644@kroah.com>

>
> Ick, you can't use "int" as an ioctl structure member, sorry.  Please
> use the proper "__u16" or "__u32" value instead.

I just looked at drm.h and nearly all the ioctls use int, this file is
included in user-space applications also at the moment, I'm worried
changing all ints to __u32 will break some of these, anyone on DRI list
care to comment?

Dave.

 >
> And what about kernels running in 64bit mode with 32bit userspace?  Care
> to provide the proper thunking layer for them too?
>
> thanks,
>
> greg k-h
>

-- 
David Airlie, Software Engineer
http://www.skynet.ie/~airlied / airlied at skynet.ie
pam_smb / Linux DECstation / Linux VAX / ILUG person


  parent reply	other threads:[~2004-05-11 23:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200405112211.i4BMBQDZ006167@hera.kernel.org>
2004-05-11 22:22 ` Greg KH
2004-05-11 23:17   ` Dave Airlie
2004-05-11 23:20   ` Dave Airlie [this message]
2004-05-11 23:34     ` Valdis.Kletnieks
2004-05-11 23:43       ` Greg KH
2004-05-12  0:07         ` Daniel Jacobowitz
2004-05-12  0:12           ` Greg KH
2004-05-12  0:12         ` H. Peter Anvin
2004-05-11 23:46       ` ioctls in drm.h Dave Airlie
2004-05-13  1:39       ` From Eric Anholt: Eric Anholt
2004-05-12  1:07     ` Jon Smirl
2004-05-12  1:15       ` Greg KH
2004-05-12 22:32     ` Linus Torvalds
2004-05-13 16:54       ` Egbert Eich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0405120018360.3826@skynet \
    --to=airlied@linux.ie \
    --cc=dri-devel@lists.sf.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®