From: Linus Torvalds <torvalds@osdl.org>
To: dri-devel@lists.sourceforge.net
Cc: Greg KH <greg@kroah.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: From Eric Anholt:
Date: Wed, 12 May 2004 15:32:12 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0405121529540.3636@evo.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0405120018360.3826@skynet>
On Wed, 12 May 2004, Dave Airlie wrote:
>
> I just looked at drm.h and nearly all the ioctls use int, this file is
> included in user-space applications also at the moment, I'm worried
> changing all ints to __u32 will break some of these, anyone on DRI list
> care to comment?
Right now, all architectures have "int" being 32-bit, so nothing should
break. Apart from sign issues, of course.
If there are pointers and "long", then those should just not exist. Never
expose kernel pointers to user mode (and you really never should pass user
pointers back), and "long" should really just be "__u32" instead (since
that is what it is on a 32-bit platform - and if it works there, then it
should work on a 64-bit platform too).
Linus
next prev parent reply other threads:[~2004-05-12 22:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200405112211.i4BMBQDZ006167@hera.kernel.org>
2004-05-11 22:22 ` Greg KH
2004-05-11 23:17 ` Dave Airlie
2004-05-11 23:20 ` Dave Airlie
2004-05-11 23:34 ` Valdis.Kletnieks
2004-05-11 23:43 ` Greg KH
2004-05-12 0:07 ` Daniel Jacobowitz
2004-05-12 0:12 ` Greg KH
2004-05-12 0:12 ` H. Peter Anvin
2004-05-11 23:46 ` ioctls in drm.h Dave Airlie
2004-05-13 1:39 ` From Eric Anholt: Eric Anholt
2004-05-12 1:07 ` Jon Smirl
2004-05-12 1:15 ` Greg KH
2004-05-12 22:32 ` Linus Torvalds [this message]
2004-05-13 16:54 ` Egbert Eich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0405121529540.3636@evo.osdl.org \
--to=torvalds@osdl.org \
--cc=dri-devel@lists.sourceforge.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®