TEA crypto in 2.4: undefined MODULE_ALIAS

TEA crypto in 2.4: undefined MODULE_ALIAS

[Meelis Roos]

I am trying to compile 2.4.27-BK on PPC and activated TEA crypto option
as a module. I get this compile error:

gcc -D__KERNEL__ -I/home/mroos/compile/linux-2.4/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -I/home/mroos/compile/linux-2.4/arch/ppc -fsigned-char -msoft-float -pipe -ffixed-r2 -Wno-uninitialized -mmultiple -mstring -DMODULE -DMODVERSIONS -include /home/mroos/compile/linux-2.4/include/linux/modversions.h  -nostdinc -iwithprefix include -DKBUILD_BASENAME=tea  -c -o tea.o tea.c
tea.c:242: error: parse error before string constant
tea.c:242: warning: type defaults to `int' in declaration of `MODULE_ALIAS'
tea.c:242: warning: function declaration isn't a prototype
tea.c:242: warning: data definition has no type or storage class

It seems that MODULE_ALIAS is undefined in 2.4. Shoulw we remove this
line from tea.c or add MODULE_ALIAS definition to 2.4?

-- 
Meelis Roos (mroos@linux.ee)

Re: TEA crypto in 2.4: undefined MODULE_ALIAS

[James Morris]

On Mon, 19 Jul 2004, Meelis Roos wrote:

> I am trying to compile 2.4.27-BK on PPC and activated TEA crypto option
> as a module. I get this compile error:
> 
> gcc -D__KERNEL__ -I/home/mroos/compile/linux-2.4/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -I/home/mroos/compile/linux-2.4/arch/ppc -fsigned-char -msoft-float -pipe -ffixed-r2 -Wno-uninitialized -mmultiple -mstring -DMODULE -DMODVERSIONS -include /home/mroos/compile/linux-2.4/include/linux/modversions.h  -nostdinc -iwithprefix include -DKBUILD_BASENAME=tea  -c -o tea.o tea.c
> tea.c:242: error: parse error before string constant
> tea.c:242: warning: type defaults to `int' in declaration of `MODULE_ALIAS'
> tea.c:242: warning: function declaration isn't a prototype
> tea.c:242: warning: data definition has no type or storage class
> 

Probably remove the line from the 2.4 version.


- James
-- 
James Morris
<jmorris@redhat.com>

[PATCH] Re: TEA crypto in 2.4: undefined MODULE_ALIAS

[Meelis Roos]

> Probably remove the line from the 2.4 version.

This patch removes the MODULE_ALIAS line from 2.4.

===== crypto/tea.c 1.1 vs edited =====
--- 1.1/crypto/tea.c	2004-06-30 08:29:33 +03:00
+++ edited/crypto/tea.c	2004-07-22 16:32:55 +03:00
@@ -239,8 +239,6 @@
 	crypto_unregister_alg(&xtea_alg);
 }

-MODULE_ALIAS("xtea");
-
 module_init(init);
 module_exit(fini);


-- 
Meelis Roos (mroos@linux.ee)