mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: CaT <cat@zip.com.au>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Greg KH <greg@kroah.com>,
	Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>,
	"Li, Shaohua" <shaohua.li@intel.com>
Subject: Re: promise controller resource alloc problems with ~2.6.8
Date: Thu, 30 Sep 2004 16:21:10 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.58.0409301615110.2403@ppc970.osdl.org> (raw)
In-Reply-To: <20040927084550.GA1134@zip.com.au>



On Mon, 27 Sep 2004, CaT wrote:
>
> I have a Promise PDC20267 card in my desktop and whilst it works
> in 2.6.8-rc2, it no longer functions beginning with at least 2.6.9-rc2.
> Latest kernel I ran is 2.6.9-rc2-bk8 and it was still not available.
> 
> dmesg does mention it though as:
> 
> PDC20267: IDE controller at PCI slot 0000:00:0d.0
> PCI: Found IRQ 11 for device 0000:00:0d.0
> PCI: Unable to reserve I/O region #5:40@1080 for device 0000:00:0d.0

Please send along /proc/ioports for both the working and the non-working 
version (that's assuming that you can boot far enough in the nw version 
to get it, of course, but the nw version is actually the more interesting 
one, so please try ;).

Also, does the attached patch (written by Shaohua Li based on suggestions 
by me) solve the problem? My suspicion is that ACPI tables do bad things, 
and that this might fix it..

		Linus

-----
===== drivers/acpi/motherboard.c 1.2 vs edited =====
--- 1.2/drivers/acpi/motherboard.c	2004-08-04 11:12:54 +08:00
+++ edited/drivers/acpi/motherboard.c	2004-08-31 11:28:27 +08:00
@@ -170,4 +170,8 @@ static int __init acpi_motherboard_init(
 	return 0;
 }
 
-subsys_initcall(acpi_motherboard_init);
+/**
+ * Reserve motherboard resources after PCI claim BARs,
+ * but before PCI assign resources for uninitialized PCI devices
+ */
+fs_initcall(acpi_motherboard_init);
===== drivers/pnp/system.c 1.10 vs edited =====
--- 1.10/drivers/pnp/system.c	2004-03-21 00:38:56 +08:00
+++ edited/drivers/pnp/system.c	2004-08-31 11:29:35 +08:00
@@ -104,4 +104,8 @@ static int __init pnp_system_init(void)
 	return pnp_register_driver(&system_pnp_driver);
 }
 
-subsys_initcall(pnp_system_init);
+/**
+ * Reserve motherboard resources after PCI claim BARs,
+ * but before PCI assign resources for uninitialized PCI devices
+ */
+fs_initcall(pnp_system_init);
===== arch/i386/pci/i386.c 1.17 vs edited =====
--- 1.17/arch/i386/pci/i386.c	2004-08-25 14:35:30 +08:00
+++ edited/arch/i386/pci/i386.c	2004-08-31 11:34:29 +08:00
@@ -164,7 +164,7 @@ static void __init pcibios_allocate_reso
 	}
 }
 
-static void __init pcibios_assign_resources(void)
+static int __init pcibios_assign_resources(void)
 {
 	struct pci_dev *dev = NULL;
 	int idx;
@@ -204,6 +204,7 @@ static void __init pcibios_assign_resour
 				pci_assign_resource(dev, PCI_ROM_RESOURCE);
 		}
 	}
+	return 0;
 }
 
 void __init pcibios_resource_survey(void)
@@ -212,8 +213,13 @@ void __init pcibios_resource_survey(void
 	pcibios_allocate_bus_resources(&pci_root_buses);
 	pcibios_allocate_resources(0);
 	pcibios_allocate_resources(1);
-	pcibios_assign_resources();
 }
+
+/**
+ * called in fs_initcall (one below subsys_initcall),
+ * give a chance for motherboard reserve resources
+ */
+fs_initcall(pcibios_assign_resources);
 
 int pcibios_enable_resources(struct pci_dev *dev, int mask)
 {

  parent reply	other threads:[~2004-09-30 23:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-27  8:45 CaT
2004-09-30 23:03 ` CaT
2004-09-30 23:21 ` Linus Torvalds [this message]
2004-09-30 23:30   ` CaT
2004-09-30 23:56     ` Linus Torvalds
2004-10-01  0:14       ` Greg KH
2004-10-01  1:23       ` CaT
2004-10-01 10:30       ` CaT
2004-10-01 14:34         ` Linus Torvalds
2004-10-02  4:57           ` CaT
2004-10-02 19:17             ` Linus Torvalds
2004-10-10  2:19               ` CaT
2004-10-10  3:15                 ` Linus Torvalds
2004-10-10  3:30                   ` Linus Torvalds
2004-10-10  4:51                   ` Greg KH
2004-10-10  5:28 Li, Shaohua
2004-10-10 17:00 ` Linus Torvalds
2004-10-12 12:52   ` CaT
2004-10-12 16:03     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0409301615110.2403@ppc970.osdl.org \
    --to=torvalds@osdl.org \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=cat@zip.com.au \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®