mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: CaT <cat@zip.com.au>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Greg KH <greg@kroah.com>,
	Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>,
	"Li, Shaohua" <shaohua.li@intel.com>
Subject: Re: promise controller resource alloc problems with ~2.6.8
Date: Thu, 30 Sep 2004 16:56:21 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.58.0409301646040.2403@ppc970.osdl.org> (raw)
In-Reply-To: <20040930233048.GC7162@zip.com.au>



On Fri, 1 Oct 2004, CaT wrote:
> 
> I have the one from 2.6.9-rc2-bk8 available to me (last time I booted I
> had time to grab lots of things) so I've attached that and the current
> one. If you need the rc3 it'll need to wait another 8 hours or so as I'm
> currently away from the PC.

This is enough, I think, although I'd also like to get the output from 
/sbin/lspci just to clarify what the devices are.

In 2.6.8 (working), you had:

	1080-10bf : 0000:00:0d.0
	  1080-1087 : ide2
	  1088-108f : ide3
	  1090-10bf : PDC20267
	10c0-10cf : 0000:00:14.1
	  10c0-10c7 : ide0
	  10c8-10cf : ide1

while in the nonworking setup the PCI code allowed 0:14.1 to be allocated 
_inside_ device 0:0d.0, like this:

	1080-10bf : 0000:00:0d.0
	  10a0-10af : 0000:00:14.1
	    10a0-10a7 : ide0
	    10a8-10af : ide1

which looks rather bogus. In fact, it looks like the device was mis-setup 
by the BIOS, and that the PCI resource changes allowed that broken setup.

The reason for that is the change in "arch/i386/pci/i386.c" to use 
"insert_resource()" instead of "request_resource()", which in turn is 
because we wanted to insert PCI resources _inside_ the system resources 
reserved by ACPI.

HOWEVER, we do _not_ want to allow insertion of PCI resources inside other 
PCI resources, and while this normally shouldn't happen, it definitely can 
happen if the BIOS has set things up incorrectly in the first place. As 
appears to be the case in your setup.

Now, the reason for using "insert_resource()" in arch/i386/pci/i386.c 
should go away with Shaohua Li's patch, so I'd love to hear if applying 
Li's patch _and_ making the "insert_resource()" be a "request_resource()" 
fixes the problem for you.

I bet it will.

Greg, we kind of left the ACPI resource management breakage pending, and 
clearly we need some resolution. Comments?

		Linus

  reply	other threads:[~2004-09-30 23:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-27  8:45 CaT
2004-09-30 23:03 ` CaT
2004-09-30 23:21 ` Linus Torvalds
2004-09-30 23:30   ` CaT
2004-09-30 23:56     ` Linus Torvalds [this message]
2004-10-01  0:14       ` Greg KH
2004-10-01  1:23       ` CaT
2004-10-01 10:30       ` CaT
2004-10-01 14:34         ` Linus Torvalds
2004-10-02  4:57           ` CaT
2004-10-02 19:17             ` Linus Torvalds
2004-10-10  2:19               ` CaT
2004-10-10  3:15                 ` Linus Torvalds
2004-10-10  3:30                   ` Linus Torvalds
2004-10-10  4:51                   ` Greg KH
2004-10-10  5:28 Li, Shaohua
2004-10-10 17:00 ` Linus Torvalds
2004-10-12 12:52   ` CaT
2004-10-12 16:03     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0409301646040.2403@ppc970.osdl.org \
    --to=torvalds@osdl.org \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=cat@zip.com.au \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®