From: Linus Torvalds <torvalds@osdl.org>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cputime_t patches broke RLIMIT_CPU
Date: Wed, 19 Jan 2005 16:09:58 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.58.0501191605380.8178@ppc970.osdl.org> (raw)
In-Reply-To: <200501192054.j0JKsiFw002526@magilla.sf.frob.com>
On Wed, 19 Jan 2005, Roland McGrath wrote:
>
> The RLIMIT_CPU limit is in seconds, not in jiffies.
This patch would seem to have its own problems, though. See:
#define secs_to_cputime(__secs) (msecs_to_jiffies(__secs * HZ))
which means that since there is no overflow checking (not in the current
tree, and not in the fixed one that uses proper parenthesis and *1000, you
can easily end up overflowing in the *1000 case, and causing nasty things.
So would it not be nicer to just keep everything in seconds instead?
Alternatively, seriously fix "secs_to_cputime()" to do the proper thing?
Or did I miss a patch and you already did that?
Linus
next prev parent reply other threads:[~2005-01-20 0:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-19 20:54 Roland McGrath
2005-01-20 0:09 ` Linus Torvalds [this message]
2005-01-20 0:26 ` Roland McGrath
2005-01-20 0:47 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0501191605380.8178@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®