From: Vadim Lobanov <vlobanov@speakeasy.net>
To: linux-kernel@vger.kernel.org
Subject: limits / PIPE_BUF?
Date: Wed, 3 May 2006 22:55:32 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0605032244230.25908@shell2.speakeasy.net> (raw)
Hi,
I was reading through the include/linux/limits.h file in order to
generate a cleanup patch for it -- a large number of #defines within
that file are no longer being used, as I surmise that they are simply
remnants of earlier implementations.
A snippet from include/linux/limits.h:
#define PIPE_BUF 4096 /* # bytes in atomic write to a pipe */
PIPE_BUF is a bit of an oddity. It is defined there, then redefined in
the arm header files, even though those header files are never included
anywhere. Also, PIPE_BUF is never referenced by name in any of the Linux
code. And yet, it is still being mentioned in some Big And Scary
Warnings (tm): fs/autofs4/waitq.c or include/linux/pipe_fs_i.h, for
example.
What's the deal with PIPE_BUF? Is its value used in the code indirectly,
so that more comments would help make this fact obvious? Or is it now
deprecated, and therefore a viable target for include/linux/limits.h
cleanups?
- Vadim Lobanov
next reply other threads:[~2006-05-04 5:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-04 5:55 Vadim Lobanov [this message]
2006-05-04 6:58 ` Arjan van de Ven
2006-05-04 16:39 ` Vadim Lobanov
2006-05-04 17:16 ` Arjan van de Ven
2006-05-04 17:50 ` Vadim Lobanov
2006-05-04 17:54 ` Arjan van de Ven
2006-05-04 18:10 ` Vadim Lobanov
2006-05-04 7:15 ` Eric Piel
2006-05-04 16:42 ` Vadim Lobanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0605032244230.25908@shell2.speakeasy.net \
--to=vlobanov@speakeasy.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®