From: Trent Piepho <xyzzy@speakeasy.org>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Markus Rechberger <mrechberger@gmail.com>,
linux-dvb@linuxtv.org, linux-kernel@vger.kernel.org,
Manu Abraham <abraham.manu@gmail.com>
Subject: Re: [linux-dvb] Re: DST/BT878 module customization (.. was: Critical points about ...)
Date: Thu, 3 May 2007 22:13:13 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0705032123340.32689@shell2.speakeasy.net> (raw)
In-Reply-To: <1178200976.12651.104.camel@localhost>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: TEXT/PLAIN; charset=X-UNKNOWN, Size: 2597 bytes --]
On Thu, 3 May 2007, Mauro Carvalho Chehab wrote:
> Em Qua, 2007-05-02 às 04:10 -0700, Trent Piepho escreveu:
> > I promise, this time it's right!
> > http://linuxtv.org/hg/~tap/dst-new
>
> Confirmed. Now the patch is properly working. My tests were done with a
> board with DST. Those are the results:
>
> 1) when DST is unselected, on a board with DST, it will print the errors
> indicating that the Kconfig items were not selected:
>
> DVB: registering new adapter (bttv0).
> DVB: Unable to find symbol dst_attach()
> frontend_init: Could not find a Twinhan DST.
> dvb-bt8xx: A frontend driver was not found for device 109e/0878 subsystem fbfb/f800
>
> The only issue is the wrong printk msg, stating that a "frontend driver"
> were not found. As this issue also happens with the current driver, due
> the usage of dvb_attach() macro, I don't see any regressions.
>
> It would be nice, however, to have a patch making dvb_attach more
> generic, by e.g. having a variant that allows passing another message.
Only this message is from dvb_attach():
> DVB: Unable to find symbol dst_attach()
Is it saying that it cannot load the module that dst_attach() is in (it
doesn't know what module that is, modprobe knows that). If you enabled dst
support and deleted the module, it would be the same.
If you turn off dvb_attach() and also disable dst, you should instead get
this message:
dst_attach: driver disabled by Kconfig
Maybe that would look nicer with a "DVB: " prefix? That would easier if it
wasn't necessary to update the printk in each boilerplate stub function. What
if one macro created these stubs....
> frontend_init: Could not find a Twinhan DST.
> dvb-bt8xx: A frontend driver was not found for device 109e/0878 subsystem fbfb/f800
These two messages are printed by the dvb-bt8xx driver, not by dvb_attach().
It would be trivial to change of course, but I'm not sure what would be
pedantically correct for both dst and non-dst based hardware.
> There's an argument against the prototype changes on dst_attach and
> dst_ca_attach since they aren't frontend.
The reason I changed that, is the dst_attach() already did return a
dvb_frontend pointer, it was just inside an enclosing structure. i.e. what
existed before:
{
struct dst_state *state;
state = dst_attach(...);
card->fe = &state->frontend;
} /* state goes out of scope */
The frontend is inside the state struct and the state pointer isn't saved
anywhere. dvb-bt8xx just saves a frontend pointer from inside the dst state
and tosses the state pointer away. So I changed that to:
card->fe = dst_attach(...);
next prev parent reply other threads:[~2007-05-04 5:13 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-30 21:17 Markus Rechberger
2007-05-01 6:40 ` [linux-dvb] " Simon Arlott
2007-05-01 9:00 ` Markus Rechberger
2007-05-01 9:31 ` Uwe Bugla
2007-05-01 22:57 ` Trent Piepho
2007-05-02 13:30 ` Manu Abraham
2007-05-02 15:51 ` Uwe Bugla
2007-05-02 16:43 ` Manu Abraham
2007-05-02 16:45 ` Manu Abraham
2007-05-02 17:33 ` Markus Rechberger
2007-05-03 11:20 ` Uwe Bugla
2007-05-03 14:44 ` Manu Abraham
2007-05-03 15:31 ` Uwe Bugla
2007-05-03 15:48 ` Manu Abraham
2007-05-03 15:59 ` Markus Rechberger
2007-05-03 16:17 ` Manu Abraham
2007-05-03 17:19 ` Markus Rechberger
[not found] ` <1178215045.12651.124.camel@localhost>
2007-05-03 19:03 ` Manu Abraham
2007-05-03 21:00 ` Markus Rechberger
2007-05-03 21:42 ` Manu Abraham
2007-05-03 22:06 ` Markus Rechberger
2007-05-03 22:31 ` Manu Abraham
2007-05-03 23:09 ` Markus Rechberger
2007-05-04 0:47 ` hermann pitton
2007-05-04 1:30 ` Uwe Bugla
2007-05-04 0:07 ` Uwe Bugla
2007-05-05 18:06 ` Mauro Carvalho Chehab
2007-05-05 18:46 ` Manu Abraham
2007-05-07 20:54 ` Mauro Carvalho Chehab
2007-05-07 21:25 ` Manu Abraham
2007-05-07 21:34 ` Michael Krufky
2007-05-07 21:49 ` Manu Abraham
2007-05-07 21:51 ` Uwe Bugla
[not found] ` <a3ef07920705031119x332db12dob997e5ebc6a8e218@mail.gmail.com>
2007-05-03 20:49 ` Markus Rechberger
2007-05-03 16:25 ` Uwe Bugla
2007-05-03 16:05 ` Uwe Bugla
2007-05-03 16:15 ` Manu Abraham
2007-05-03 16:30 ` Michael Krufky
2007-05-03 16:35 ` Manu Abraham
2007-05-07 23:33 ` Trent Piepho
2007-05-08 0:00 ` Manu Abraham
2007-05-01 14:55 ` Mauro Carvalho Chehab
2007-05-01 16:40 ` [linux-dvb] " Uwe Bugla
2007-05-01 18:30 ` Uwe Bugla
2007-05-01 18:50 ` Simon Arlott
2007-05-01 19:34 ` Uwe Bugla
2007-05-01 20:35 ` Simon Arlott
2007-05-01 21:29 ` Uwe Bugla
2007-05-01 19:20 ` e9hack
2007-05-01 19:26 ` Uwe Bugla
2007-05-01 23:16 ` Trent Piepho
2007-05-02 2:03 ` Mauro Carvalho Chehab
2007-05-02 11:10 ` Trent Piepho
2007-05-02 12:04 ` Uwe Bugla
2007-05-03 14:02 ` Mauro Carvalho Chehab
2007-05-03 15:15 ` Manu Abraham
2007-05-03 15:36 ` Uwe Bugla
2007-05-04 5:13 ` Trent Piepho [this message]
2007-05-04 9:23 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0705032123340.32689@shell2.speakeasy.net \
--to=xyzzy@speakeasy.org \
--cc=abraham.manu@gmail.com \
--cc=linux-dvb@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mrechberger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®