From: Steven Rostedt <rostedt@goodmis.org>
To: Gregory Haskins <ghaskins@novell.com>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org,
peterz@infradead.org, linux-rt-users@vger.kernel.org,
dbahi@novell.com
Subject: Re: [PATCH 1/3] sched: enable interrupts and drop rq-lock during newidle balancing
Date: Mon, 23 Jun 2008 20:11:54 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0806232011220.8540@gandalf.stny.rr.com> (raw)
In-Reply-To: <20080623230440.31515.97377.stgit@lsg.lsg.lab.novell.com>
On Mon, 23 Jun 2008, Gregory Haskins wrote:
>
> We do find_busiest_groups() et. al. without locks held for normal balancing,
> so lets do it for newidle as well. It will allow other cpus to make
> forward progress (against our RQ) while we try to balance and allow
> some interrupts to occur.
>
I don't see anything wrong with this patch. I'll probably queue it up for
-rt8 since it is too late for -rt7.
-- Steve
next prev parent reply other threads:[~2008-06-24 0:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 23:04 [PATCH 0/3] RT: scheduler newidle enhancements Gregory Haskins
2008-06-23 23:04 ` [PATCH 1/3] sched: enable interrupts and drop rq-lock during newidle balancing Gregory Haskins
2008-06-24 0:11 ` Steven Rostedt [this message]
2008-06-24 10:13 ` Peter Zijlstra
2008-06-24 13:15 ` [PATCH 1/3] sched: enable interrupts and drop rq-lock duringnewidle balancing Gregory Haskins
2008-06-24 12:24 ` Peter Zijlstra
2008-06-24 12:39 ` [PATCH 1/3] sched: enable interrupts and drop rq-lockduringnewidle balancing Gregory Haskins
2008-06-23 23:04 ` [PATCH 2/3] sched: only run newidle if previous task was CFS Gregory Haskins
2008-06-24 9:58 ` Peter Zijlstra
2008-06-24 10:38 ` Peter Zijlstra
2008-06-23 23:04 ` [PATCH 3/3] sched: terminate newidle balancing once at least one task has moved over Gregory Haskins
2008-06-24 0:50 ` Nick Piggin
2008-06-24 1:07 ` Steven Rostedt
2008-06-24 1:26 ` Nick Piggin
2008-06-24 2:39 ` Gregory Haskins
2008-06-24 1:46 ` Nick Piggin
2008-06-24 2:59 ` Gregory Haskins
2008-06-24 10:13 ` Peter Zijlstra
2008-06-24 13:18 ` [PATCH 3/3] sched: terminate newidle balancing once at leastone " Gregory Haskins
2008-06-24 13:31 ` Peter Zijlstra
2008-06-24 16:55 ` [PATCH 3/3] sched: terminate newidle balancing once atleastone " Gregory Haskins
2008-06-24 19:44 ` Peter Zijlstra
2008-06-24 0:15 ` [PATCH 0/3] RT: scheduler newidle enhancements Steven Rostedt
2008-06-24 1:51 ` Gregory Haskins
2008-06-27 20:29 [PATCH 0/3] sched: newidle and RT wake-buddy fixes Gregory Haskins
2008-06-27 20:29 ` [PATCH 1/3] sched: enable interrupts and drop rq-lock during newidle balancing Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0806232011220.8540@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=dbahi@novell.com \
--cc=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®