From: Steven Rostedt <rostedt@goodmis.org>
To: Gregory Haskins <ghaskins@novell.com>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org,
peterz@infradead.org, linux-rt-users@vger.kernel.org,
dbahi@novell.com
Subject: Re: [PATCH 0/3] RT: scheduler newidle enhancements
Date: Mon, 23 Jun 2008 20:15:04 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0806232014070.8540@gandalf.stny.rr.com> (raw)
In-Reply-To: <20080623225645.31515.36393.stgit@lsg.lsg.lab.novell.com>
On Mon, 23 Jun 2008, Gregory Haskins wrote:
>
> Hi Ingo, Steven, Thomas,
> The following series applies to 25.4-rt6 and is "ready for inclusion" from
> my perspective. However, due to their nature I am sure we will want to get
> some review feedback before being considered for acceptance.
>
> These patches are probably suitable for consideration for
> mainline/sched-devel as well, but PREEMPT_RT gains the biggest boost from
> them since it tends to context switch much more frequently than mainline.
>
> This series makes some adjustments to the way we do newidle balancing.
> These tweaks were discovered while doing some related scheduler R&D that is
> not quite ready for the light of day. But these patches do offer a
> substantial boost (6-12%) in network performance. They may help in other
> areas as well, but networking is where our focus remains currently.
>
> I think the patch 1/3 is a good one, but it requires careful review. Patch
> 2/3 is based upon some work I had seen PeterZ submit, so its possible to
> just pull his work (if it hasnt been already) as opposed to this patch, if
> desired. Lastly, Patch 3/3 is a bit controversial so I put it last for
> easier cherry picking of the first two. It does help in our testing, but it
> will have to be reviewed carefully.
>
> Comments/feedback/bugfixes more than welcome.
Greg,
I don't see anything wrong with these patches. If either Ingo or Peter
have any issues, I hope they speak up soon. I'll queue them all for 25-rt8
(after I get rt7 out the door).
-- Steve
next prev parent reply other threads:[~2008-06-24 0:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 23:04 Gregory Haskins
2008-06-23 23:04 ` [PATCH 1/3] sched: enable interrupts and drop rq-lock during newidle balancing Gregory Haskins
2008-06-24 0:11 ` Steven Rostedt
2008-06-24 10:13 ` Peter Zijlstra
2008-06-24 13:15 ` [PATCH 1/3] sched: enable interrupts and drop rq-lock duringnewidle balancing Gregory Haskins
2008-06-24 12:24 ` Peter Zijlstra
2008-06-24 12:39 ` [PATCH 1/3] sched: enable interrupts and drop rq-lockduringnewidle balancing Gregory Haskins
2008-06-23 23:04 ` [PATCH 2/3] sched: only run newidle if previous task was CFS Gregory Haskins
2008-06-24 9:58 ` Peter Zijlstra
2008-06-24 10:38 ` Peter Zijlstra
2008-06-23 23:04 ` [PATCH 3/3] sched: terminate newidle balancing once at least one task has moved over Gregory Haskins
2008-06-24 0:50 ` Nick Piggin
2008-06-24 1:07 ` Steven Rostedt
2008-06-24 1:26 ` Nick Piggin
2008-06-24 2:39 ` Gregory Haskins
2008-06-24 1:46 ` Nick Piggin
2008-06-24 2:59 ` Gregory Haskins
2008-06-24 10:13 ` Peter Zijlstra
2008-06-24 13:18 ` [PATCH 3/3] sched: terminate newidle balancing once at leastone " Gregory Haskins
2008-06-24 13:31 ` Peter Zijlstra
2008-06-24 16:55 ` [PATCH 3/3] sched: terminate newidle balancing once atleastone " Gregory Haskins
2008-06-24 19:44 ` Peter Zijlstra
2008-06-24 0:15 ` Steven Rostedt [this message]
2008-06-24 1:51 ` [PATCH 0/3] RT: scheduler newidle enhancements Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0806232014070.8540@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=dbahi@novell.com \
--cc=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®