From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: marcelo.tosatti@cyclades.com, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [TRIVIAL PATCH] 2.4.25pre7 warning fix
Date: Wed, 28 Jan 2004 09:42:30 -0200 (BRST) [thread overview]
Message-ID: <Pine.LNX.4.58L.0401280939400.1311@logos.cnet> (raw)
In-Reply-To: <m3u12hcc9f.fsf@defiant.pm.waw.pl>
On Tue, 27 Jan 2004, Krzysztof Halasa wrote:
> Hi,
>
> The attached patch fixes the following warning msg:
>
> time.c:435: warning: `do_gettimeoffset_cyclone' defined but not used
>
> There is no need to define functions which do just { return 0; } and
> which aren't called by anything.
>
> (In case CONFIG_X86_SUMMIT is defined, there is another (real)
> do_gettimeoffset_cyclone() function, and it is referenced - but
> it's simply not related to this empty function).
Applied, thanks.
Btw, why do we need cyclone_setup() for !CONFIG_X86_SUMMIT ?
/* No-cyclone stubs */
#ifndef CONFIG_X86_SUMMIT
int __init cyclone_setup(char *str)
{
printk(KERN_ERR "cyclone: Kernel not compiled with
CONFIG_X86_SUMMIT, cannot use the cyclone-timer.\n");
return 1;
}
next prev parent reply other threads:[~2004-01-28 11:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-27 21:28 Krzysztof Halasa
2004-01-28 11:42 ` Marcelo Tosatti [this message]
2004-01-28 22:17 ` Krzysztof Halasa
2004-01-29 16:38 ` Krzysztof Halasa
2004-01-29 19:22 ` john stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58L.0401280939400.1311@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®