mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: [PATCH] smbfs: Large File Support (3/3) (fwd)
@ 2004-01-30 11:05 Marcelo Tosatti
  2004-01-30 16:03 ` Urban Widmark
  0 siblings, 1 reply; 2+ messages in thread
From: Marcelo Tosatti @ 2004-01-30 11:05 UTC (permalink / raw)
  To: Urban Widmark, linux-kernel


Urban?

---------- Forwarded message ----------
Date: Wed, 28 Jan 2004 14:21:53 -0500
From: Arjan van de Ven <arjanv@redhat.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] smbfs: Large File Support (3/3)

On Wed, 2004-01-28 at 06:05, Linux Kernel Mailing List wrote:

> diff -Nru a/include/linux/smb.h b/include/linux/smb.h
> --- a/include/linux/smb.h	Wed Jan 28 04:02:56 2004
> +++ b/include/linux/smb.h	Wed Jan 28 04:02:56 2004
> @@ -85,7 +85,7 @@
>  	uid_t		f_uid;
>  	gid_t		f_gid;
>  	kdev_t		f_rdev;
> -	off_t		f_size;
> +	loff_t		f_size;
>  	time_t		f_atime;
>  	time_t		f_mtime;
>  	time_t		f_ctime;

ehhmmmm doesn't this change the userspace ABI incompatibly ???

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] smbfs: Large File Support (3/3) (fwd)
  2004-01-30 11:05 [PATCH] smbfs: Large File Support (3/3) (fwd) Marcelo Tosatti
@ 2004-01-30 16:03 ` Urban Widmark
  0 siblings, 0 replies; 2+ messages in thread
From: Urban Widmark @ 2004-01-30 16:03 UTC (permalink / raw)
  To: Arjan van de Ven; +Cc: Marcelo Tosatti, linux-kernel

On Fri, 30 Jan 2004, Marcelo Tosatti wrote:

> 
> Urban?
> 
> ---------- Forwarded message ----------
> Date: Wed, 28 Jan 2004 14:21:53 -0500
> From: Arjan van de Ven <arjanv@redhat.com>
> To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH] smbfs: Large File Support (3/3)
> 
> On Wed, 2004-01-28 at 06:05, Linux Kernel Mailing List wrote:
> 
> > diff -Nru a/include/linux/smb.h b/include/linux/smb.h
> > --- a/include/linux/smb.h	Wed Jan 28 04:02:56 2004
> > +++ b/include/linux/smb.h	Wed Jan 28 04:02:56 2004
> > @@ -85,7 +85,7 @@
> >  	uid_t		f_uid;
> >  	gid_t		f_gid;
> >  	kdev_t		f_rdev;
> > -	off_t		f_size;
> > +	loff_t		f_size;
> >  	time_t		f_atime;
> >  	time_t		f_mtime;
> >  	time_t		f_ctime;
> 
> ehhmmmm doesn't this change the userspace ABI incompatibly ???

How would userspace get access to a smb_fattr struct?
(Which ioctl/syscall, etc? Not that they can include the header.)

It is used internally to keep data that you would otherwise find in the
inode, and data is copied to/from the corresponding inode fields for some
operations.

What am I missing?

/Urban


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-01-30 16:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-01-30 11:05 [PATCH] smbfs: Large File Support (3/3) (fwd) Marcelo Tosatti
2004-01-30 16:03 ` Urban Widmark

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®