mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zwane Mwaikambo <zwane@arm.linux.org.uk>
To: Ashok Raj <ashok.raj@intel.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, mingo@elte.hu,
	tony.luck@intel.com, gregkh@suse.de, hch@infradead.org
Subject: Re: Deferred handling of writes to /proc/irq/xx/smp_affinity
Date: Thu, 28 Apr 2005 00:48:04 -0600 (MDT)	[thread overview]
Message-ID: <Pine.LNX.4.61.0504280039490.12903@montezuma.fsmlabs.com> (raw)
In-Reply-To: <20050427221538.A30702@unix-os.sc.intel.com>

On Wed, 27 Apr 2005, Ashok Raj wrote:

> Hi Andrew and all
> 
> It is safe to re-program rte entries in ioapic only when an intr is pending. 
> Existing code does this incorrectly by reprogamming rte entries immediatly
> when a value is written to /proc/irq/xx/smp_affinity. IRQ_BALANCE code in 
> kernel does this right, but /proc/irq needs to be handled the same way so that 
> user mode irq_balancer wont lock up systems or loose interrupts in the race.
> 
> This is already fixed in ia64, introduced for i386 and x86_64.
> 
> since this touches 3 arch's managing in -mm for trial would be best to make
> sure nothing is broken, before considering for main line.

Ashok, thanks for doing this, i only have minor nitpicks, can we avoid 
the wrapper for irq_desc and just index it directly? And could we use 
static inline functions for MOVE_IRQ and SET_IRQ_INFO macros and use nop 
functions where required.

Thanks,
	Zwane


      parent reply	other threads:[~2005-04-28  6:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-28  5:15 Ashok Raj
2005-04-28  5:56 ` Greg KH
2005-04-28  6:48 ` Zwane Mwaikambo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0504280039490.12903@montezuma.fsmlabs.com \
    --to=zwane@arm.linux.org.uk \
    --cc=akpm@osdl.org \
    --cc=ashok.raj@intel.com \
    --cc=gregkh@suse.de \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®