From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] dup_mmap: update comment on new vma
Date: Mon, 6 Jun 2005 20:51:06 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.61.0506062049460.5000@goblin.wat.veritas.com> (raw)
Remove part of comment on linking new vma in dup_mmap: since anon_vma
rmap came in, try_to_unmap_one knows the vma without needing find_vma.
But add a comment to note that here vma is inserted without mmap_sem.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
kernel/fork.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
--- 2.6.12-rc6/kernel/fork.c 2005-05-25 18:09:19.000000000 +0100
+++ linux/kernel/fork.c 2005-06-04 20:41:55.000000000 +0100
@@ -249,8 +249,9 @@ static inline int dup_mmap(struct mm_str
/*
* Link in the new vma and copy the page table entries:
- * link in first so that swapoff can see swap entries,
- * and try_to_unmap_one's find_vma find the new vma.
+ * link in first so that swapoff can see swap entries.
+ * Note that, exceptionally, here the vma is inserted
+ * without holding mm->mmap_sem.
*/
spin_lock(&mm->page_table_lock);
*pprev = tmp;
reply other threads:[~2005-06-06 19:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0506062049460.5000@goblin.wat.veritas.com \
--to=hugh@veritas.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®