mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] dup_mmap: update comment on new vma
@ 2005-06-06 19:51 Hugh Dickins
  0 siblings, 0 replies; only message in thread
From: Hugh Dickins @ 2005-06-06 19:51 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

Remove part of comment on linking new vma in dup_mmap: since anon_vma
rmap came in, try_to_unmap_one knows the vma without needing find_vma.
But add a comment to note that here vma is inserted without mmap_sem.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
---

 kernel/fork.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

--- 2.6.12-rc6/kernel/fork.c	2005-05-25 18:09:19.000000000 +0100
+++ linux/kernel/fork.c	2005-06-04 20:41:55.000000000 +0100
@@ -249,8 +249,9 @@ static inline int dup_mmap(struct mm_str
 
 		/*
 		 * Link in the new vma and copy the page table entries:
-		 * link in first so that swapoff can see swap entries,
-		 * and try_to_unmap_one's find_vma find the new vma.
+		 * link in first so that swapoff can see swap entries.
+		 * Note that, exceptionally, here the vma is inserted
+		 * without holding mm->mmap_sem.
 		 */
 		spin_lock(&mm->page_table_lock);
 		*pprev = tmp;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-06-06 19:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-06-06 19:51 [PATCH] dup_mmap: update comment on new vma Hugh Dickins

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®