mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Pavel Machek <pavel@ucw.cz>,
	Nigel Cunningham <ncunningham@cyclades.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 13/13] update swsusp use of swap_info
Date: Sat, 9 Jul 2005 01:15:03 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.61.0507090111440.13391@goblin.wat.veritas.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0507090057340.13391@goblin.wat.veritas.com>

Aha, swsusp dips into swap_info[], better update it to swap_lock.  It's
bitflipping flags with 0xFF, so get_swap_page will allocate from only
the one chosen device: let's change that to flip SWP_WRITEOK.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
---

 kernel/power/swsusp.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

--- swap12/kernel/power/swsusp.c	2005-07-07 12:33:21.000000000 +0100
+++ swap13/kernel/power/swsusp.c	2005-07-08 19:15:59.000000000 +0100
@@ -178,9 +178,9 @@ static int swsusp_swap_check(void) /* Th
 	len=strlen(resume_file);
 	root_swap = 0xFFFF;
 
-	swap_list_lock();
+	spin_lock(&swap_lock);
 	for (i=0; i<MAX_SWAPFILES; i++) {
-		if (swap_info[i].flags == 0) {
+		if (!swap_info[i].flags & SWP_WRITEOK) {
 			swapfile_used[i]=SWAPFILE_UNUSED;
 		} else {
 			if (!len) {
@@ -201,7 +201,7 @@ static int swsusp_swap_check(void) /* Th
 			}
 		}
 	}
-	swap_list_unlock();
+	spin_unlock(&swap_lock);
 	return (root_swap != 0xffff) ? 0 : -ENODEV;
 }
 
@@ -215,12 +215,12 @@ static void lock_swapdevices(void)
 {
 	int i;
 
-	swap_list_lock();
+	spin_lock(&swap_lock);
 	for (i = 0; i< MAX_SWAPFILES; i++)
 		if (swapfile_used[i] == SWAPFILE_IGNORED) {
-			swap_info[i].flags ^= 0xFF;
+			swap_info[i].flags ^= SWP_WRITEOK;
 		}
-	swap_list_unlock();
+	spin_unlock(&swap_lock);
 }
 
 /**

  parent reply	other threads:[~2005-07-09  0:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-09  0:00 [PATCH 00/13] some swapfile patches Hugh Dickins
2005-07-09  0:01 ` [PATCH 01/13] update swapfile i_sem comment Hugh Dickins
2005-07-09  0:01 ` [PATCH 02/13] correct swapfile nr_good_pages Hugh Dickins
2005-07-09  0:02 ` [PATCH 03/13] move destroy_swap_extents calls Hugh Dickins
2005-07-09  0:03 ` [PATCH 04/13] swap extent list is ordered Hugh Dickins
2005-07-09  0:04 ` [PATCH 05/13] show span of swap extents Hugh Dickins
2005-07-09  0:05 ` [PATCH 06/13] swap unsigned int consistency Hugh Dickins
2005-07-09  0:06 ` [PATCH 07/13] freeing update swap_list.next Hugh Dickins
2005-07-09  0:07 ` [PATCH 08/13] get_swap_page drop swap_list_lock Hugh Dickins
2005-07-09  0:08 ` [PATCH 09/13] scan_swap_map restyled Hugh Dickins
2005-07-09  0:09 ` [PATCH 10/13] scan_swap_map drop swap_device_lock Hugh Dickins
2005-07-09  0:10 ` [PATCH 11/13] scan_swap_map latency breaks Hugh Dickins
2005-07-09  0:11 ` [PATCH 12/13] swap_lock replace list+device Hugh Dickins
2005-07-09  0:15 ` Hugh Dickins [this message]
2005-07-09 11:13   ` [PATCH 14/13] swsusp mod needed parentheses Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0507090111440.13391@goblin.wat.veritas.com \
    --to=hugh@veritas.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncunningham@cyclades.com \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®