* [PATCH] rmap don't test rss
@ 2005-07-09 0:46 Hugh Dickins
0 siblings, 0 replies; only message in thread
From: Hugh Dickins @ 2005-07-09 0:46 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
Remove the three get_mm_counter(mm, rss) tests from rmap.c: there was a
time when testing rss was important to avoid a particular race between
dup_mmap and the anonmm rmap; but now it's just a rather silly pseudo-
optimization, made even more obscure by the get_mm_counter macro.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
mm/rmap.c | 7 +------
1 files changed, 1 insertion(+), 6 deletions(-)
--- 2.6.13-rc2-mm1/mm/rmap.c 2005-07-07 12:33:21.000000000 +0100
+++ linux/mm/rmap.c 2005-07-09 01:20:41.000000000 +0100
@@ -290,8 +290,6 @@ static int page_referenced_one(struct pa
pte_t *pte;
int referenced = 0;
- if (!get_mm_counter(mm, rss))
- goto out;
address = vma_address(page, vma);
if (address == -EFAULT)
goto out;
@@ -522,8 +520,6 @@ static int try_to_unmap_one(struct page
pte_t pteval;
int ret = SWAP_AGAIN;
- if (!get_mm_counter(mm, rss))
- goto out;
address = vma_address(page, vma);
if (address == -EFAULT)
goto out;
@@ -771,8 +767,7 @@ static int try_to_unmap_file(struct page
if (vma->vm_flags & (VM_LOCKED|VM_RESERVED))
continue;
cursor = (unsigned long) vma->vm_private_data;
- while (get_mm_counter(vma->vm_mm, rss) &&
- cursor < max_nl_cursor &&
+ while ( cursor < max_nl_cursor &&
cursor < vma->vm_end - vma->vm_start) {
try_to_unmap_cluster(cursor, &mapcount, vma);
cursor += CLUSTER_SIZE;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-07-09 0:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-07-09 0:46 [PATCH] rmap don't test rss Hugh Dickins
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®