From: Hugh Dickins <hugh@veritas.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: torvalds@osdl.org, michael.bishop@APPIQ.com,
linux-kernel@vger.kernel.org, nickpiggin@yahoo.com.au
Subject: Re: More info for DSM w/r/t sunffb on 2.6.15-rc6
Date: Sat, 24 Dec 2005 01:21:07 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.61.0512240104440.17764@goblin.wat.veritas.com> (raw)
In-Reply-To: <20051223.154509.86780332.davem@davemloft.net>
On Fri, 23 Dec 2005, David S. Miller wrote:
>
> So I think something as simple as returning -EINVAL in the SBUS
> framebuffer mmap() driver if VM_SHARED is not set would be sufficient
> to deal with this.
That certainly gets my vote: it should work around the bug correctly
and effectively without adding any complexity.
Though really the check ought to be in the sparc and sparc64
io_remap_pfn_range, which are the guilty parties giving shared write
access even when none has been asked for. But I guess it's too risky
to add failures or change behaviour down there at this stage.
Those "prot = __pgprot(pg_iobits);" lines - any idea why they ever
got inserted? I guess to add _PAGE_E in the sparc64 case, and
whatever the equivalent was in the earlier sparc cases?
Can they safely be corrected early in 2.6.16?
Hugh
next prev parent reply other threads:[~2005-12-24 1:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-23 16:23 Michael Bishop
2005-12-23 19:19 ` David S. Miller
2005-12-23 20:53 ` Linus Torvalds
2005-12-23 23:45 ` David S. Miller
2005-12-24 1:21 ` Hugh Dickins [this message]
2005-12-24 7:46 ` David S. Miller
2005-12-24 9:07 ` Hugh Dickins
2006-03-21 10:28 ` David S. Miller
2005-12-24 8:32 ` Linus Torvalds
2005-12-24 9:16 ` Hugh Dickins
2005-12-24 20:08 ` David S. Miller
[not found] <DF925A10E7204748977502BECE3D1123015C4DCE@exch02.appiq.com>
2005-12-24 8:29 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0512240104440.17764@goblin.wat.veritas.com \
--to=hugh@veritas.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.bishop@APPIQ.com \
--cc=nickpiggin@yahoo.com.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®