From: Hugh Dickins <hugh@veritas.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: VM_ZONE_RECLAIM_MODE warning in kernel/sysctl.c
Date: Mon, 23 Jan 2006 20:59:53 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.61.0601232035450.6596@goblin.wat.veritas.com> (raw)
Hi Christoph,
I'm puzzled why I who only pretend to have NUMA get this compiler warning
kernel/sysctl.c:881: warning: initialization from incompatible pointer type
but people who really have NUMA don't. Specifying the address of an int
instead of a function looks unhealthy to me: could you please test this
plausible but possibly nonsense patch below, correct it where necessary,
and send it in? Thanks.
Heed NUMA VM_ZONE_RECLAIM_MODE compiler warning in kernel/sysctl.c.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
--- 2.6.16-rc1-git4/kernel/sysctl.c 2006-01-22 09:22:41.000000000 +0000
+++ linux/kernel/sysctl.c 2006-01-23 13:25:22.000000000 +0000
@@ -878,7 +878,8 @@ static ctl_table vm_table[] = {
.maxlen = sizeof(zone_reclaim_mode),
.mode = 0644,
.proc_handler = &proc_dointvec,
- .strategy = &zero,
+ .strategy = &sysctl_intvec,
+ .extra1 = &zero,
},
#endif
{ .ctl_name = 0 }
next reply other threads:[~2006-01-23 20:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-23 20:59 Hugh Dickins [this message]
2006-01-23 21:02 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0601232035450.6596@goblin.wat.veritas.com \
--to=hugh@veritas.com \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®