* VM_ZONE_RECLAIM_MODE warning in kernel/sysctl.c
@ 2006-01-23 20:59 Hugh Dickins
2006-01-23 21:02 ` Christoph Lameter
0 siblings, 1 reply; 2+ messages in thread
From: Hugh Dickins @ 2006-01-23 20:59 UTC (permalink / raw)
To: Christoph Lameter; +Cc: Andrew Morton, linux-kernel
Hi Christoph,
I'm puzzled why I who only pretend to have NUMA get this compiler warning
kernel/sysctl.c:881: warning: initialization from incompatible pointer type
but people who really have NUMA don't. Specifying the address of an int
instead of a function looks unhealthy to me: could you please test this
plausible but possibly nonsense patch below, correct it where necessary,
and send it in? Thanks.
Heed NUMA VM_ZONE_RECLAIM_MODE compiler warning in kernel/sysctl.c.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
--- 2.6.16-rc1-git4/kernel/sysctl.c 2006-01-22 09:22:41.000000000 +0000
+++ linux/kernel/sysctl.c 2006-01-23 13:25:22.000000000 +0000
@@ -878,7 +878,8 @@ static ctl_table vm_table[] = {
.maxlen = sizeof(zone_reclaim_mode),
.mode = 0644,
.proc_handler = &proc_dointvec,
- .strategy = &zero,
+ .strategy = &sysctl_intvec,
+ .extra1 = &zero,
},
#endif
{ .ctl_name = 0 }
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: VM_ZONE_RECLAIM_MODE warning in kernel/sysctl.c
2006-01-23 20:59 VM_ZONE_RECLAIM_MODE warning in kernel/sysctl.c Hugh Dickins
@ 2006-01-23 21:02 ` Christoph Lameter
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Lameter @ 2006-01-23 21:02 UTC (permalink / raw)
To: Hugh Dickins; +Cc: Andrew Morton, linux-kernel
On Mon, 23 Jan 2006, Hugh Dickins wrote:
> Heed NUMA VM_ZONE_RECLAIM_MODE compiler warning in kernel/sysctl.c.
This is already fixed in Andrews tree.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-01-23 21:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-23 20:59 VM_ZONE_RECLAIM_MODE warning in kernel/sysctl.c Hugh Dickins
2006-01-23 21:02 ` Christoph Lameter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®